Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add tests for omni-jobs & add more context in system messages for jobs #27048

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Oct 11, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Jira: OC-377

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #27048 (56e4876) into develop (9685810) will increase coverage by 1.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27048      +/-   ##
===========================================
+ Coverage    40.12%   41.20%   +1.08%     
===========================================
  Files          847      819      -28     
  Lines        18422    17933     -489     
  Branches      2050     1988      -62     
===========================================
- Hits          7391     7389       -2     
+ Misses       10747    10256     -491     
- Partials       284      288       +4     
Flag Coverage Δ
e2e 41.20% <0.00%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 marked this pull request as ready for review October 12, 2022 14:21
@murtaza98 murtaza98 requested review from a team as code owners October 12, 2022 14:21
@murtaza98 murtaza98 dismissed KevLehman’s stale review October 20, 2022 11:39

Requested changes done

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 17, 2022
@kodiakhq kodiakhq bot merged commit 6bbf331 into develop Nov 17, 2022
@kodiakhq kodiakhq bot deleted the omni-jobs-tests branch November 17, 2022 11:23
gabriellsh added a commit that referenced this pull request Nov 21, 2022
…age-ignore-reactivity

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Chore: removing useEndpointData from license api (#26634)
  Chore: Create unique index for `E2EKey` field (#27301)
  [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842)
  Chore: UserAvatar wrapper missing key in RoomForeword (#27300)
  Chore: Add deprecation warning to settings (#27295)
  Chore: Refactor LeaveTeam to Typescript (#27197)
  [FIX] Sidebar context menu in searchList (#23830)
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
  [FIX] Set default value "false" for global search. (#25568)
  Regression: Custom fields form not showing in user profile nor admin (#27244)
  [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201)
  Chore: Remove unused css (#27289)
  Chore: also send thread to channel translations (#27242)
  [FIX] Marketplace app details page back-button behavior (#27062)
  Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048)
  Chore: Fix missing license for forks (#27258)
  i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants