Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix omnichannel chat forwarding not working #28117

Merged
merged 10 commits into from
Feb 28, 2023

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Feb 22, 2023

Requires RocketChat/fuselage#988

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/OC-689

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested a review from a team as a code owner February 22, 2023 13:12
@murtaza98 murtaza98 added this to the 6.0.0 milestone Feb 22, 2023
@murtaza98 murtaza98 requested a review from a team February 22, 2023 13:13
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only fixes the symptoms, not the actual problem, we need to refactor the useDepartmentList hook instead, let me take a stab at it

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@3418e20). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #28117   +/-   ##
==========================================
  Coverage           ?   44.81%           
==========================================
  Files              ?      765           
  Lines              ?    14893           
  Branches           ?     2069           
==========================================
  Hits               ?     6674           
  Misses             ?     7929           
  Partials           ?      290           
Flag Coverage Δ
e2e 44.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

MartinSchoeler
MartinSchoeler previously approved these changes Feb 23, 2023
KevLehman
KevLehman previously approved these changes Feb 24, 2023
@KevLehman KevLehman dismissed their stale review February 24, 2023 21:11

dismissing as pipe is still failing

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 26, 2023
@murtaza98 murtaza98 requested a review from KevLehman February 27, 2023 13:04
Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the requested changes and everything works as expected, code also looks good, approving.

@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 28, 2023
@kodiakhq kodiakhq bot merged commit 6e5ba71 into develop Feb 28, 2023
@kodiakhq kodiakhq bot deleted the reg-forward-chat-issue branch February 28, 2023 15:14
gabriellsh added a commit that referenced this pull request Feb 28, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression:  Fix mentioning rooms with special chars (#28206)
  Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151)
  Chore: anonymous e2e test dispatch error (#28171)
  Regression: Remove unnecessary messages from Email transcript (#28165)
  Regression: Update color tokens for voip footer (#28197)
  Regression: Image Attachment Description size (#28149)
  Regression: Fix omnichannel chat forwarding not working (#28117)
  Regression: Support generating pdfs from queue (#28162)
  Regression: Regular users were not able to leave federated rooms (#28148)
  Regression: Fix slash commands (#28168)
  Regression: Incorrect installation flow on app detail and upload app pages (#28173)
  replace deprecated color tokens (#28164)
  Regression: Fix toggle theme breaking UI (#28161)
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants