-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Fix omnichannel chat forwarding not working #28117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only fixes the symptoms, not the actual problem, we need to refactor the useDepartmentList
hook instead, let me take a stab at it
Codecov Report
@@ Coverage Diff @@
## develop #28117 +/- ##
==========================================
Coverage ? 44.81%
==========================================
Files ? 765
Lines ? 14893
Branches ? 2069
==========================================
Hits ? 6674
Misses ? 7929
Partials ? 290
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/components/AutoCompleteDepartmentMultiple.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the requested changes and everything works as expected, code also looks good, approving.
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix mentioning rooms with special chars (#28206) Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151) Chore: anonymous e2e test dispatch error (#28171) Regression: Remove unnecessary messages from Email transcript (#28165) Regression: Update color tokens for voip footer (#28197) Regression: Image Attachment Description size (#28149) Regression: Fix omnichannel chat forwarding not working (#28117) Regression: Support generating pdfs from queue (#28162) Regression: Regular users were not able to leave federated rooms (#28148) Regression: Fix slash commands (#28168) Regression: Incorrect installation flow on app detail and upload app pages (#28173) replace deprecated color tokens (#28164) Regression: Fix toggle theme breaking UI (#28161) Chore: Remove meteor build --debug option (#28170) fix: hide register workspace option for non-admin users (#28154)
Requires RocketChat/fuselage#988
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/OC-689
Steps to test or reproduce
Further comments