Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove meteor build --debug option #28170

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 25, 2023

today, the way we run our tests, there is no advantage in running using the debug build. The opposite, it makes the UI slower, and requires more server resources.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #28170 (9e7c1d4) into develop (fb7251b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28170      +/-   ##
===========================================
+ Coverage    44.93%   44.95%   +0.02%     
===========================================
  Files          766      766              
  Lines        14903    14903              
  Branches      2070     2070              
===========================================
+ Hits          6696     6700       +4     
+ Misses        7915     7910       -5     
- Partials       292      293       +1     
Flag Coverage Δ
e2e 44.91% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 25, 2023 01:31
@ggazzo ggazzo requested a review from a team as a code owner February 25, 2023 01:31
@ggazzo ggazzo merged commit d785129 into develop Feb 25, 2023
@ggazzo ggazzo deleted the chore/remove-debug branch February 25, 2023 01:35
gabriellsh added a commit that referenced this pull request Feb 27, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
gabriellsh added a commit that referenced this pull request Feb 28, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression:  Fix mentioning rooms with special chars (#28206)
  Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151)
  Chore: anonymous e2e test dispatch error (#28171)
  Regression: Remove unnecessary messages from Email transcript (#28165)
  Regression: Update color tokens for voip footer (#28197)
  Regression: Image Attachment Description size (#28149)
  Regression: Fix omnichannel chat forwarding not working (#28117)
  Regression: Support generating pdfs from queue (#28162)
  Regression: Regular users were not able to leave federated rooms (#28148)
  Regression: Fix slash commands (#28168)
  Regression: Incorrect installation flow on app detail and upload app pages (#28173)
  replace deprecated color tokens (#28164)
  Regression: Fix toggle theme breaking UI (#28161)
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant