Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Hide Workspace registration feature for non-admin users #28154

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Feb 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CS-359

Steps to test or reproduce

Further comments

@csuadev csuadev added this to the 6.0.0 milestone Feb 24, 2023
@csuadev csuadev requested a review from a team as a code owner February 24, 2023 15:02
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #28154 (b375a27) into develop (fb7251b) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28154      +/-   ##
===========================================
- Coverage    44.93%   44.81%   -0.12%     
===========================================
  Files          766      766              
  Lines        14903    14903              
  Branches      2070     2070              
===========================================
- Hits          6696     6679      -17     
- Misses        7915     7933      +18     
+ Partials       292      291       -1     
Flag Coverage Δ
e2e 44.78% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
Copy link
Member

ggazzo commented Feb 24, 2023

I'm afraid this is a regression not a FIX

@csuadev csuadev changed the title [FIX] Hide Workspace registration feature for non-admin users Regression: Hide Workspace registration feature for non-admin users Feb 24, 2023
@geekgonecrazy geekgonecrazy added this pull request to the merge queue Feb 24, 2023
@geekgonecrazy geekgonecrazy removed this pull request from the merge queue due to a manual request Feb 24, 2023
@geekgonecrazy geekgonecrazy merged commit b45c41d into develop Feb 24, 2023
@geekgonecrazy geekgonecrazy deleted the fix/CS-359-register-workspace-only-admin branch February 24, 2023 21:05
gabriellsh added a commit that referenced this pull request Feb 27, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
gabriellsh added a commit that referenced this pull request Feb 28, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression:  Fix mentioning rooms with special chars (#28206)
  Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151)
  Chore: anonymous e2e test dispatch error (#28171)
  Regression: Remove unnecessary messages from Email transcript (#28165)
  Regression: Update color tokens for voip footer (#28197)
  Regression: Image Attachment Description size (#28149)
  Regression: Fix omnichannel chat forwarding not working (#28117)
  Regression: Support generating pdfs from queue (#28162)
  Regression: Regular users were not able to leave federated rooms (#28148)
  Regression: Fix slash commands (#28168)
  Regression: Incorrect installation flow on app detail and upload app pages (#28173)
  replace deprecated color tokens (#28164)
  Regression: Fix toggle theme breaking UI (#28161)
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants