Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update documentation #28719

Merged
merged 9 commits into from
Apr 4, 2023
Merged

docs: update documentation #28719

merged 9 commits into from
Apr 4, 2023

Conversation

SANTHOSH-MAMIDISETTI
Copy link
Contributor

@SANTHOSH-MAMIDISETTI SANTHOSH-MAMIDISETTI commented Mar 31, 2023 •
edited by hugocostadev
Loading

Proposed changes (including videos or screenshots)

fixed the broken minimum requirements and how can I help links in README.md .

Issue(s)

fix #28746
fix #28494

Steps to test or reproduce

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SANTHOSH-MAMIDISETTI SANTHOSH-MAMIDISETTI changed the title docs:fixed broken links in README.md docs: update documentation Mar 31, 2023
@hugocostadev
Copy link
Contributor

Hi there, thanks for your contribution! 🚀 💯

@SANTHOSH-MAMIDISETTI
Copy link
Contributor Author

Hi there, thanks for your contribution! rocket 100

This is the first time I ever actually contributed to open-source @hugocostadev . Thanks sir . I would actually like to contribute to opensource , but don't know where to start hence did that .

@hugocostadev
Copy link
Contributor

Hi there, thanks for your contribution! rocket 100

This is the first time I ever actually contributed to open-source @hugocostadev . Thanks sir . I would actually like to contribute to opensource , but don't know where to start hence did that .

This is a great start! Find a project that you are interested in, check the issues, and get one that you think you can fix it!

hugocostadev
hugocostadev previously approved these changes Mar 31, 2023
View reviewed changes
@SANTHOSH-MAMIDISETTI
Copy link
Contributor Author

SANTHOSH-MAMIDISETTI commented Mar 31, 2023 •
edited
Loading

@hugocostadev sir , I didn't understand why the pull request you approved now has not yet reflected in the repositories' main README.md . I mean will it take time to reflect over there (or) it hasn't be merged/ pulled yet ? or any other thing .
I mean , am I missing something or is that the way how it works.?

@hugocostadev
Copy link
Contributor

Approve does not mean that the PR it's merged, to be merged the CI (robot) needs to run checks and if everything is correct it'll be merged

@hugocostadev hugocostadev mentioned this pull request Apr 2, 2023
Closed
@hugocostadev
Copy link
Contributor

We are fixing a CI error , after that your PR will be merged

@SANTHOSH-MAMIDISETTI
Copy link
Contributor Author

SANTHOSH-MAMIDISETTI commented Apr 2, 2023 •
edited
Loading

We are fixing a CI error , after that your PR will be merged

waiting for it to be done sir , Thanks for the reply 😄 @hugocostadev

@hugocostadev hugocostadev mentioned this pull request Apr 3, 2023
Closed
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #28719 (665cc37) into develop (b25610c) will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28719      +/-   ##
===========================================
- Coverage    45.39%   44.28%   -1.12%     
===========================================
  Files          726      717       -9     
  Lines        14279    14075     -204     
  Branches      2213     2199      -14     
===========================================
- Hits          6482     6233     -249     
- Misses        7490     7551      +61     
+ Partials       307      291      -16
Flag Coverage Δ
e2e 44.24% <ø> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2023
@kodiakhq kodiakhq bot merged commit 5bc44f3 into RocketChat:develop Apr 4, 2023
gabriellsh added a commit that referenced this pull request Apr 4, 2023
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
edf2df9 
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
@SANTHOSH-MAMIDISETTI SANTHOSH-MAMIDISETTI deleted the documentation branch June 15, 2023 21:14
@SANTHOSH-MAMIDISETTI SANTHOSH-MAMIDISETTI restored the documentation branch June 15, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocostadev hugocostadev hugocostadev approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rocketchat.md link to system requirements page error 404 Docs: "How can I help?" wrong readme link
4 participants
@SANTHOSH-MAMIDISETTI @CLAassistant @hugocostadev @ggazzo