Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rooms model 4/4 #28742

Merged
merged 5 commits into from
Apr 3, 2023
Merged

refactor: Rooms model 4/4 #28742

merged 5 commits into from
Apr 3, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman marked this pull request as ready for review March 31, 2023 22:19
@KevLehman KevLehman requested a review from a team as a code owner March 31, 2023 22:19
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #28742 (f390be2) into develop (3129e8b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28742      +/-   ##
===========================================
- Coverage    45.27%   45.25%   -0.03%     
===========================================
  Files          727      727              
  Lines        14287    14287              
  Branches      2216     2216              
===========================================
- Hits          6468     6465       -3     
+ Misses        7515     7514       -1     
- Partials       304      308       +4     
Flag Coverage Δ
e2e 45.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman requested a review from a team as a code owner March 31, 2023 23:27
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2023
@ggazzo ggazzo merged commit 7b5e655 into develop Apr 3, 2023
@ggazzo ggazzo deleted the refactor/rooms-model-4 branch April 3, 2023 14:49
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants