Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(file-upload:s3): Fix missing store import #28781

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 3, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #28781 (9c22c1d) into develop (80bd6f0) will increase coverage by 2.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28781      +/-   ##
===========================================
+ Coverage    42.91%   45.41%   +2.49%     
===========================================
  Files          713      726      +13     
  Lines        14192    14279      +87     
  Branches      2195     2213      +18     
===========================================
+ Hits          6091     6485     +394     
+ Misses        7805     7489     -316     
- Partials       296      305       +9     
Flag Coverage Δ
e2e 45.37% <ø> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix:(file-upload:s3): Fix missing store import regression (file-upload:s3): Fix missing store import Apr 3, 2023
@ggazzo ggazzo changed the title regression (file-upload:s3): Fix missing store import regression(file-upload:s3): Fix missing store import Apr 3, 2023
@rodrigok rodrigok merged commit 0e92378 into develop Apr 3, 2023
@rodrigok rodrigok deleted the fix/s3 branch April 3, 2023 23:42
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants