Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rooms model 3/4 #28736

Merged
merged 7 commits into from
Mar 31, 2023
Merged

refactor: Rooms model 3/4 #28736

merged 7 commits into from
Mar 31, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team as a code owner March 31, 2023 19:03
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #28736 (a49e4e6) into refactor/rooms-model-2 (4824357) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           refactor/rooms-model-2   #28736      +/-   ##
==========================================================
- Coverage                   45.26%   45.17%   -0.10%     
==========================================================
  Files                         741      741              
  Lines                       14471    14471              
  Branches                     2236     2236              
==========================================================
- Hits                         6551     6537      -14     
- Misses                       7615     7629      +14     
  Partials                      305      305              
Flag Coverage Δ
e2e 45.13% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from refactor/rooms-model-2 to develop March 31, 2023 21:54
@ggazzo ggazzo requested review from a team as code owners March 31, 2023 21:54
@ggazzo ggazzo merged commit de8f27d into develop Mar 31, 2023
@ggazzo ggazzo deleted the refactor/rooms-model-3 branch March 31, 2023 21:55
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants