fix: livechat agent status set to available after reactivation #31651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61e570d The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31651 +/- ##
===========================================
+ Coverage 54.55% 54.57% +0.02%
===========================================
Files 2283 2282 -1
Lines 50279 50248 -31
Branches 10255 10249 -6
===========================================
- Hits 27431 27425 -6
+ Misses 20356 20334 -22
+ Partials 2492 2489 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Feb 8, 2024
abhinavkrin
commented
Feb 12, 2024
abhinavkrin
force-pushed
the
fix/agent-status-after-reactivation
branch
from
6778bed to
287bd55
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
abhinavkrin
force-pushed
the
fix/agent-status-after-reactivation
branch
from
15a2def to
f414956
Compare
MarcosSpessatto
requested changes
Feb 21, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
MarcosSpessatto
previously approved these changes
Feb 22, 2024
matheusbsilva137
requested changes
Feb 22, 2024
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
matheusbsilva137
approved these changes
Feb 23, 2024
MarcosSpessatto
approved these changes
Feb 27, 2024
lmauromb
approved these changes
Feb 27, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
ricardogarim
pushed a commit
that referenced
this pull request
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR introduces a fix to the livechat agent status handling within Rocket.Chat. Previously, when a deactivated user, assigned as a livechat agent, was reactivated, their status in the livechat system was automatically set to 'Available'. This behavior was unintended as it could lead to conversations being assigned to agents who might not be ready to handle them. With this update, reactivated users will retain the 'Not Available' status until manually set to 'Available' by an admin or the agent themselves, ensuring better control and management of agent availability.
livechant-agent-2024-02-05_22.15.46.mp4
Issue(s)
This PR addresses the issue where livechat agent status was incorrectly set to 'Available' upon the reactivation of a deactivated user. Deactivated users should not be made available when they get activated.
Steps to test or reproduce
To test this fix, follow these steps:
Further comments
CORE-46