fix: presence for mobiles with duplicated connections #31895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7203870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31895 +/- ##
===========================================
+ Coverage 54.56% 54.60% +0.03%
===========================================
Files 2280 2283 +3
Lines 50244 50279 +35
Branches 10248 10255 +7
===========================================
+ Hits 27418 27455 +37
+ Misses 20340 20336 -4
- Partials 2486 2488 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
fix-presence-duplicated-connections
branch
from
0e4d715 to
7203870
Compare
KevLehman
approved these changes
Mar 5, 2024
ggazzo
approved these changes
Mar 5, 2024
sampaiodiego
added a commit
that referenced
this pull request
Mar 5, 2024
Merged
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
ricardogarim
pushed a commit
that referenced
this pull request
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The changes from #31487 added a connection ID for REST login requests, which caused an undesired effect of those requests being considered WS connections. That doesn't affect the web client since it only uses REST login requests with username and password (it doesn't use the "resume" login type). But the mobile uses the "resume" login type via REST to validate if stored credentials are still valid, which was causing "duplicated connection" entries being created for mobile, leading to mobile users being considered online forever (until a server restart).
With these changes we're making sure for every "resume" login action there is indeed an opened WS connection before we create this connection record on DB.
Issue(s)
closes #31768
closes #31873
Steps to test or reproduce
Further comments