Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RoomHeader keyboard navigability #31837

Merged
merged 11 commits into from
Feb 29, 2024
Merged

chore: RoomHeader keyboard navigability #31837

merged 11 commits into from
Feb 29, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SR-6

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: c8c1940

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (d92c0c7) to head (c8c1940).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31837      +/-   ##
===========================================
- Coverage    54.64%   54.56%   -0.09%     
===========================================
  Files         2279     2279              
  Lines        50194    50208      +14     
  Branches     10235    10238       +3     
===========================================
- Hits         27431    27398      -33     
- Misses       20284    20326      +42     
- Partials      2479     2484       +5     
Flag Coverage Δ
e2e 53.48% <34.61%> (-0.15%) ⬇️
e2e-api 40.08% <ø> (+0.02%) ⬆️
unit 76.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review February 29, 2024 19:49
@dougfabris dougfabris requested a review from a team as a code owner February 29, 2024 19:49
@ggazzo ggazzo merged commit 8629672 into develop Feb 29, 2024
43 checks passed
@ggazzo ggazzo deleted the chore/roomHeader-focus branch February 29, 2024 21:08
gabriellsh added a commit that referenced this pull request Mar 6, 2024
…tMarkdown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: improve useJumpToMessage (#31907)
  feat: Add `link` action to composer toolbar (#31679)
  chore: replace `PaletteStyleTag` in favor of fuselage component (#31839)
  fix: presence for mobiles with duplicated connections (#31895)
  fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720)
  fix: livechat agent status set to available after reactivation (#31651)
  chore: Deprecate `insertOrUpdateUser` method (#31884)
  chore: update ts version on recently merged package (#31885)
  chore: move utilitary functions out of ee folder (#31207)
  chore: Remove references to EE code from the app bridges (#31757)
  fix: Room import doesn't honor the specified owner (#31803)
  fix: message parser emphasis black hole (#31868)
  chore: remove hardcoded position for message date (#31866)
  feat: show date on message's scroll (#31572)
  chore: `RoomHeader` keyboard navigability (#31837)
  fix: Login page breaking when handling not expected errors (#31804)
@dougfabris dougfabris added this to the 6.7 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants