Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Room import doesn't honor the specified owner #31803

Merged
merged 15 commits into from
Mar 4, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Feb 21, 2024

Proposed changes (including videos or screenshots)

  • Stop using the importer agent as the room owner for imported channels and groups. Prioritize the room owner specified in the import process instead (eg second field in the CSV import file);
  • Fixed issue where the room owner specified in a CSV import file couldn't be inserted in the room on import even if specified in the members field.

Issue(s)

Steps to test or reproduce

Import CSV docs

Further comments

SUP-496

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: f8e5c1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.58%. Comparing base (000f601) to head (f8e5c1f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31803   +/-   ##
========================================
  Coverage    54.57%   54.58%           
========================================
  Files         2283     2279    -4     
  Lines        50280    50231   -49     
  Branches     10251    10244    -7     
========================================
- Hits         27440    27418   -22     
+ Misses       20347    20326   -21     
+ Partials      2493     2487    -6     
Flag Coverage Δ
e2e 53.54% <ø> (+0.01%) ⬆️
e2e-api 40.02% <ø> (+<0.01%) ⬆️
unit 76.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 added this to the 6.7 milestone Feb 21, 2024
@matheusbsilva137 matheusbsilva137 changed the title fix: Imported rooms have an incorrect owner fix: Room import doesn't honor the specified owner Feb 21, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review February 21, 2024 19:55
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner February 21, 2024 19:55
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case to cover the DM behavior as well?

apps/meteor/tests/e2e/imports.spec.ts Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 4, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 4, 2024
@kodiakhq kodiakhq bot merged commit 09ee4fd into develop Mar 4, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the fix/csv-importer-room-owner branch March 4, 2024 17:07
gabriellsh added a commit that referenced this pull request Mar 6, 2024
…tMarkdown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: improve useJumpToMessage (#31907)
  feat: Add `link` action to composer toolbar (#31679)
  chore: replace `PaletteStyleTag` in favor of fuselage component (#31839)
  fix: presence for mobiles with duplicated connections (#31895)
  fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720)
  fix: livechat agent status set to available after reactivation (#31651)
  chore: Deprecate `insertOrUpdateUser` method (#31884)
  chore: update ts version on recently merged package (#31885)
  chore: move utilitary functions out of ee folder (#31207)
  chore: Remove references to EE code from the app bridges (#31757)
  fix: Room import doesn't honor the specified owner (#31803)
  fix: message parser emphasis black hole (#31868)
  chore: remove hardcoded position for message date (#31866)
  feat: show date on message's scroll (#31572)
  chore: `RoomHeader` keyboard navigability (#31837)
  fix: Login page breaking when handling not expected errors (#31804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants