Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1777 styles user settings dialog #1884

Merged
merged 43 commits into from
Feb 26, 2021
Merged

1777 styles user settings dialog #1884

merged 43 commits into from
Feb 26, 2021

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1777

JohannesDoberer and others added 8 commits February 2, 2021 07:58
@JohannesDoberer
remove header and apply mobile nav
7b34a0d
@JohannesDoberer
Merge branch 'master' into Remove-header-of-user-settings-dialog
8afcb19 
* master:
  travis slack integration update
  Update FD Styles to v.14 in E2E App (SAP#1817)
  Update Core fundamental styles from v.11 to v.14 (SAP#1805)
  Update fiddle version to 1.8.1 (SAP#1843)
  Move user settings config to an own section (SAP#1833)
  merging with master (SAP#1744)
  Release v1.8.1 (SAP#1851)
  fixed id_token only oidc flow (SAP#1840)
  Removing spinner background (SAP#1849)
  Wrong release tag for nightly in ng support lib  SAP#1844 (SAP#1847)
  Fixing publishing problem (SAP#1844)
  Fixing CheckMark issue (SAP#1822)
  fix query param subscriptions issue (SAP#1839)

# Conflicts:
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@JohannesDoberer
css and merge conflict issues
226631a
@JohannesDoberer
Merge branch 'master' into Remove-header-of-user-settings-dialog
6cb4a7b 
* master:
  Document web components based MFE functionality (SAP#1708)
  Add documentation about breaking changes in Luigi 1.9.0 due to FD Sty… (SAP#1857)
@JohannesDoberer
styling of header
3382599
@UlianaMunich
naming refatoring
0ca1c94
@UlianaMunich
add SAP css variable
c4a2f93
@UlianaMunich
Merge branch 'master' of github.com:UlianaMunich/luigi into 1777-styl…
18ec0c4 
…es-user-settings-dialog
@legteodav legteodav self-assigned this Feb 11, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 16 milestone Feb 11, 2021
@JohannesDoberer JohannesDoberer self-assigned this Feb 11, 2021
JohannesDoberer
JohannesDoberer reviewed Feb 15, 2021
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2021-02-15 um 19 58 09
I guess it was not introduced in this pr but it would be nice to fix it here

JohannesDoberer
JohannesDoberer requested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look to my suggestions. It fixes the scroll issue and the gap between last entry and bottom for all viewports.
In addition the spec of fiori3 has bigger icons for the left nav.
Also please take a look to the font size and weight.

core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Show resolved Hide resolved
core/src/UserSettingsDialog.html Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
UlianaMunich and others added 18 commits February 22, 2021 09:46
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
a404f7f 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
4c19041 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
0f83df8 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
f272be5 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
8cb4b90 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
07ef652 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
18d5e57 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
9b4845a 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich @JohannesDoberer
Update core/src/UserSettingsDialog.html
380e909 
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
@UlianaMunich
use SAP Theming css variables for theming of Fiori 3
ca624f6
@JohannesDoberer
small bug fix and extended user settings for account
242859f
@UlianaMunich
make changes for darrk theme
4f8a149
@JohannesDoberer
Test test
dc78a54
@JohannesDoberer
test
b689cf0
@UlianaMunich
Add max-width and height for dialog window and commetn out some conte…
4c4675d 
…nt in user settings dialog
@UlianaMunich
adjust colors of background for User Settings dialog based on Fiori 3
ee521f3
@UlianaMunich
return custom settings for User settings dialog
5e31d82
@UlianaMunich
Align header of the User Settings dialog with Fiori 3
41ea8ba
@UlianaMunich UlianaMunich merged commit 4f0b4f2 into SAP:usersettings-refinements Feb 26, 2021
@UlianaMunich UlianaMunich deleted the 1777-styles-user-settings-dialog branch February 26, 2021 10:28
hardl added a commit that referenced this pull request Feb 27, 2021
@hardl @JohannesDoberer @UlianaMunich
Usersettings refinements (#1906)
1da6144 
* Remove header of user settings dialog (#1866)

* small test fix because header does not exist anymore

* fix input fields and scroll bug on edge (#1879)

* usersettings refinements merge conflicts (#1887)

* Style User Settings Dialog according to Fiori 3 (#1884)

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Mar 1, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Mar 1, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl @JohannesDoberer @UlianaMunich
Usersettings refinements (SAP#1906)
2a16162 
* Remove header of user settings dialog (SAP#1866)

* small test fix because header does not exist anymore

* fix input fields and scroll bug on edge (SAP#1879)

* usersettings refinements merge conflicts (SAP#1887)

* Style User Settings Dialog according to Fiori 3 (SAP#1884)

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legteodav legteodav legteodav approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@legteodav legteodav

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 16
Development

Successfully merging this pull request may close these issues.
3 participants
@UlianaMunich @JohannesDoberer @legteodav