Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REBASE only]: Migrate notebooks and add new amalthea #418

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[REBASE only]: Migrate notebooks and add new amalthea #418

wants to merge 6 commits into from

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 20, 2024 •
edited
Loading

This combines all changes for the notebooks migration and new amalthea operator.

NOTE: This should be rebased on main. DO NOT SQUASH AND MERGE. WHEN updating this branch remember to REABASE only too.

/deploy renku=feat-jupyter-free-sessions amalthea-sessions=feat-add-cloud-storage renku-notebooks=feat-add-amalthea-session-cache renku-gateway=feat-add-renku-refresh-token-for-data-service renku-ui=andrea/use-data-service-sessions-2.0 extra-values=amalthea-sessions.deployCrd=false #notest

@olevski olevski requested a review from a team as a code owner September 20, 2024 09:47
@olevski olevski marked this pull request as draft September 20, 2024 09:50
@olevski olevski changed the title Migrate notebooks and add new amalthea [REBASE only]: Migrate notebooks and add new amalthea Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11144424058

Details

  • 1981 of 2432 (81.46%) changed or added relevant lines in 56 files are covered.
  • 44 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-4.7%) to 85.758%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/api/classes/cloud_storage/existing.py 7 8 87.5%
components/renku_data_services/notebooks/api/classes/server.py 55 56 98.21%
components/renku_data_services/session/apispec_base.py 7 8 87.5%
components/renku_data_services/notebooks/api/amalthea_patches/cloudstorage.py 1 3 33.33%
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py 16 18 88.89%
components/renku_data_services/notebooks/util/retries.py 13 15 86.67%
components/renku_data_services/base_models/core.py 50 53 94.34%
components/renku_data_services/notebooks/api/classes/user.py 8 11 72.73%
components/renku_data_services/utils/sqlalchemy.py 12 15 80.0%
components/renku_data_services/notebooks/config/dynamic.py 24 28 85.71%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/auth.py 1 83.16%
components/renku_data_services/crc/blueprints.py 1 92.88%
components/renku_data_services/crc/db.py 1 85.68%
components/renku_data_services/crc/models.py 1 85.19%
components/renku_data_services/session/orm.py 1 98.57%
components/renku_data_services/authn/keycloak.py 2 47.22%
components/renku_data_services/repositories/blueprints.py 2 82.93%
components/renku_data_services/session/db.py 2 91.13%
components/renku_data_services/message_queue/config.py 7 70.0%
components/renku_data_services/app_config/config.py 26 89.07%
Totals Coverage Status
Change from base Build 11140653681: -4.7%
Covered Lines: 12844
Relevant Lines: 14977
💛 - Coveralls

@olevski olevski force-pushed the release-amaltheas-migration branch 4 times, most recently from 30923b5 to a45bec2 Compare September 25, 2024 15:17
leafty added a commit that referenced this pull request Sep 26, 2024
@leafty
Merge data connectors and notebooks/amalthea migration
f02def2 
Merges:
* #418
* #407

Merge remote-tracking branch 'origin/feat-add-cloudstorage' into leafty/leafty/feat-namespaced-data-connectors-merge-amalthea-migration
@leafty leafty mentioned this pull request Sep 26, 2024
Draft
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 1, 2024

You can access the deployment of this PR at https://renku-ci-ds-418.dev.renku.ch

olevski and others added 6 commits October 2, 2024 15:09
@olevski
feat: add new apispec for the new amalthea sessions (#360)
f489378
@olevski
feat!: expand environments specification (#338)
52710cd 
This is a breaking change in the API. It requires changes in the UI for it to be fully useful.
@olevski
feat: run notebooks in data service (#375)
ac8db66 
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>

squashme: resolve package version conflicts
@sgaist @olevski
feat: ensure notebook endpoints do their job (#388)
319d133 
This work brings the notebook related endpoints to a working state
to serve as replacement for the renku-notebooks external service.

Short summary:
- API tests have been added
- Code has been fixed to answer / handle exception
- Automated test cluster creation has been added using k3d

---------

Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch>
@olevski @sgaist
feat: use cloud storage from amalthea (#387)
8174633 
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
@olevski
feat: perf improvements for amalthea sessions (#411)
be5272b
@olevski olevski force-pushed the release-amaltheas-migration branch from 7fcfa17 to be5272b Compare October 2, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @coveralls @RenkuBot @sgaist