fix: allow session launcher parameters to be reset #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change in the API. It requires changes in the UI for it to be fully useful.
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
This work brings the notebook related endpoints to a working state to serve as replacement for the renku-notebooks external service. Short summary: - API tests have been added - Code has been fixed to answer / handle exception - Automated test cluster creation has been added using k3d --------- Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch>
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
|
This change is part of the following stack: Change managed by git-spice. |
olevski
force-pushed
the
reset-session-launcher-params
branch
2 times, most recently
from
1a841b3
to
659480c
Compare
squashme: use the amalthea session cache
Allows the API to accept None as input for args, command and the session launcher resource class ID so that they can be reset to their defaults in patch endpoints.
olevski
force-pushed
the
reset-session-launcher-params
branch
from
659480c
to
4ccfc03
Compare
olevski
force-pushed
the
release-amaltheas-migration
branch
from
7fcfa17
to
be5272b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the API to accept None as input for args, command and the session launcher resource class ID so that they can be reset to their defaults in patch endpoints.