Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alternate vertical splits #1

Merged
merged 22 commits into from
Feb 20, 2024
Merged

Add alternate vertical splits #1

merged 22 commits into from
Feb 20, 2024

Conversation

YuanTingHsieh
Copy link

@YuanTingHsieh YuanTingHsieh commented Feb 17, 2024 •
edited
Loading

Just showing how to add a unit test.

You might need to rebase your secureboost branch based on main

david-cortes and others added 22 commits January 31, 2024 05:17
@david-cortes
[R] Remove enable_categorical parameter (dmlc#10018)
df7cf74
@david-cortes
[R] rename slice to avoid dplyr conflict (dmlc#10017)
5e00a71
@ammarsaf
[doc] Fix typos in code (dmlc#10023)
c53d59f 
change `resutls` to `results`
@david-cortes
[R] Add optional check on column names matching in predict (dmlc#10020
1e72dc1 
)
@david-cortes
[R] rename proxy dmatrix -> data batch (dmlc#10016)
0955213
@razdoburdin
[sync]. Add partition builder. (dmlc#10011)
234674a 

---------

Co-authored-by: Dmitry Razdoburdin <>
@hcho3 @trivialfis
[CI] Test building for 32-bit arch (dmlc#10021)
4dfbe2a 
* [CI] Test building for 32-bit arch

* Update CMakeLists.txt

* Fix yaml

* Use Debian container

* Remove -Werror for 32-bit

* Revert "Remove -Werror for 32-bit"

This reverts commit c652bc6.

* Don't error for overloaded-virtual warning

* Ignore some warnings from dmlc-core

* Fix compiler warnings

* Fix formatting

* Apply suggestions from code review

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>

* Add more cast

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
@david-cortes @trivialfis
[R] Document handling of indexes (dmlc#10019)
662854c 

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
@david-cortes
[R] allow using seed with regular RNG (dmlc#10029)
a730c7e
@hcho3
[Doc] Fix formatting for R package doc (dmlc#10030)
f2095f1
@david-cortes
[R] switch to URI reader (dmlc#10024)
4de8662
@ZiyueXu77 @YuanTingHsieh
Add additional data split mode to cover the secure vertical pipeline
70e6ca6
@ZiyueXu77 @YuanTingHsieh
Add IsSecure info and update corresponding functions
a54ea6a
@ZiyueXu77 @YuanTingHsieh
Modify evaluate_splits to block non-label owners to perform hist comp…
6fe61dd 
…ute under secure scenario
@ZiyueXu77 @YuanTingHsieh
Continue using Allgather for best split sync for secure vertical, equ…
1c2b7ed 
…valent to broadcast
@ZiyueXu77 @YuanTingHsieh
Modify histogram sync scheme for secure vertical case, can identify g…
b36ff2b 
…lobal best split, but need to further apply split correctly
@ZiyueXu77 @YuanTingHsieh
Sync cut informaiton across clients, full pipeline works for testing …
0707731 
…case
@ZiyueXu77 @YuanTingHsieh
Code cleanup, phase 1 of alternative vertical pipeline finished
dce7609
@ZiyueXu77 @YuanTingHsieh
Code clean
6cebc31
@ZiyueXu77 @YuanTingHsieh
change kColS to kColSecure to avoid confusion with kCols
1562f52
@YuanTingHsieh
Add one unit test
f31c824
@ZiyueXu77
Merge branch 'SecureBoost' into add_alternate_vertical_splits
6fcbe02
@ZiyueXu77 ZiyueXu77 merged commit 967e307 into ZiyueXu77:SecureBoost Feb 20, 2024
@YuanTingHsieh YuanTingHsieh deleted the add_alternate_vertical_splits branch February 20, 2024 18:37
@YuanTingHsieh YuanTingHsieh restored the add_alternate_vertical_splits branch February 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YuanTingHsieh @ZiyueXu77 @david-cortes @ammarsaf @razdoburdin @hcho3