-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] new connecotor of Elasticsearch source(#2553) #2554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add connector-v2 e2e-testcase & docs
reference:#2499
No problem |
sink { | ||
Console {} | ||
|
||
# If you would like to get more information about how to configure seatunnel and see full list of sink plugins, | ||
# please go to https://seatunnel.apache.org/docs/category/sink-v2 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to use use Assert sink to check datatype or combine source and sink into one test like #2499 ?
Container.ExecResult sinkEsResult = executeSeaTunnelFlinkJob("/elasticsearch/fakesource_to_elasticsearch.conf"); | ||
Assertions.assertEquals(0, sinkEsResult.getExitCode()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate testcase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a duplicate.You need a had docs index before source from elasticsearch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate with FakeSourceToElasticsearchIT.java
testcase?
} | ||
|
||
@Test | ||
public void testFakeSourceToConsoleSink() throws IOException, InterruptedException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to testElasticsearchSourceToConsoleSink
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -0,0 +1,58 @@ | |||
# Elasticsearch | |||
|
|||
## Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update doc to match new format, reference: #2625
* [Improve][build] Improved scope of maven-shade-plugin * Excludes log dependencies in maven-shade-plugin * common/base module need skip shading * common/base module need skip shading
* fix the e2e exec error in win10-os,because line separator.
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
…#2639) * [Bug] fix flink-start didn't load plugins/${pluginName}/lib/* Co-authored-by: laglangyue <laglangyue@qq.com>
* [Connector-V2][JDBC-connector] Add DM source and sink connector
* [Improve][e2e] flink container only copy required connector jars * rename flink-e2e-common * remove useless imported * [Improve][e2e] flink sql container refactoring * remove useless imported * remove useless * [Improve][e2e] spark container only copy required connector jars * change for code review * Use e2e-common module directly * checkstyle * code format
…odule (apache#2702) * [Improve][build] The e2e module don't depend on the connector*-dist module * fix connector type error * fix flink sql
* [build] Change the packing mode of seatunnel connectors * change the activation mode Use '!' can cause '<activeByDefault>true' failed * simple starter code * fix starter jar output file name
* [Feature][Connector-V2] Add mongodb connecter sink * Add license header * Add spark mongodb sink e2e * Add spark mongodb sink e2e * Fix * Fix * Fix
…pache#2711) * [Bug][Connector-V2-e2e] Fix jackson dependency conflict * [Bug][Connector-V2-spark-examples] Fix jackson dependency conflict
…e#2715) * [Bug]fix path split exception in win10,not check file existed * improve code Co-authored-by: laglangyue <laglangyue@qq.com>
* [Improve][e2e] Improved e2e start sleep * update * update * fix 2675
…ton pattern (apache#2706) * remove singleton pattern for SeaTunnelContext * rename SeaTunnelContext to JobContext and fix checkstyle * fix checkstyle * put the constructor on top
* [Starter] [Core] Modify connector v2 starter and remove spark/flink in seatunnel-core-starter
…pache#2637) * [hotfix] data,time,timestamp convert for spark * fxi the instant convert * revert to nullable field value * Update exception info * Update exception info Co-authored-by: laglangyue <laglangyue@qq.com> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
…ure (apache#2701) * [Improve][Connector-V2] Refactor hdfs file sink codes
* Fix SeaTunnelRow convert to json format error * Rename `bootstrap.server` to `bootstrap.servers` in kafka source config * Remove `kafka.` prefix in sink producer configuration key
* [Feature][Connector-V2] Add iceberg source connector Co-authored-by: wanghailin <wanghaiin@apache.org>
* [Feat][UI] Update task service in the project. * [Feat][UI] Update task service in the project.
…l into dev-20220820 � Conflicts: � seatunnel-connectors-v2/connector-elasticsearch/src/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java � seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java � seatunnel-e2e/seatunnel-flink-connector-v2-e2e/pom.xml � seatunnel-e2e/seatunnel-spark-connector-v2-e2e/pom.xml
Replace with #2821, so I will close this pr. |
Purpose of this pull request
close #2553
Check list
New License Guide