Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: provide reply definition #992

Closed
wants to merge 55 commits into from

Conversation

Tenischev
Copy link
Member


title: "Provide more solid definition of the reply"

This PR adds definition of the reply message and fix a drift of naming response-reply in the spec.


Related issue(s):
Resolves: #980


char0n and others added 30 commits September 21, 2022 16:17
…jects (asyncapi#796)

Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
Co-authored-by: ue85540 <ue85540@sbb.ch>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Tenischev
Copy link
Member Author

@derberg as requested 😄

@GreenRover
Copy link
Collaborator

Change makes sense for me.

@Tenischev Tenischev marked this pull request as ready for review January 10, 2024 21:49
@Tenischev Tenischev changed the base branch from next-major-spec to master January 10, 2024 21:58
…ition

# Conflicts:
#	examples/adeo-kafka-request-reply-asyncapi.yml
#	scripts/converter/package-lock.json
#	scripts/converter/package.json
#	spec/asyncapi.md
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Tenischev . Would you mind fixing the conflicts so I can +1 this?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 21, 2024
@github-actions github-actions bot closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide definition for the reply