improving logging for subcommand failure #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Jan 9, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jan 12, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.44.2` -> `v0.45.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - nogo: use original source files instead of coverage-instrumented by [@​emmaxy](https://togithub.com/emmaxy) in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - Allow compilers to be overwritten in go_grpc_library() by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812) - update documentation for 0.44 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813) - Temporarily undo deprecation of `//proto:go_grpc` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818) - Rename bazel_features polyfill to prevent conflicts by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817) - Handle prerelease versions in polyfill by [@​illicitonion](https://togithub.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821) - Extend gomock to allow passing an source_importpath instead of library when operating in source mode by [@​therve](https://togithub.com/therve) in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) - Fix coverage collection with modified `COVERAGE_DIR` env variable by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820) - improving logging for subcommand failure by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824) - release rules go 0.45.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825) #### New Contributors - [@​emmaxy](https://togithub.com/emmaxy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - [@​therve](https://togithub.com/therve) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) **Full Changelog**: bazel-contrib/rules_go@v0.44.2...v0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.44.2` -> `v0.45.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - nogo: use original source files instead of coverage-instrumented by [@​emmaxy](https://togithub.com/emmaxy) in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - Allow compilers to be overwritten in go_grpc_library() by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812) - update documentation for 0.44 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813) - Temporarily undo deprecation of `//proto:go_grpc` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818) - Rename bazel_features polyfill to prevent conflicts by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817) - Handle prerelease versions in polyfill by [@​illicitonion](https://togithub.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821) - Extend gomock to allow passing an source_importpath instead of library when operating in source mode by [@​therve](https://togithub.com/therve) in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) - Fix coverage collection with modified `COVERAGE_DIR` env variable by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820) - improving logging for subcommand failure by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824) - release rules go 0.45.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825) #### New Contributors - [@​emmaxy](https://togithub.com/emmaxy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - [@​therve](https://togithub.com/therve) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) **Full Changelog**: bazel-contrib/rules_go@v0.44.2...v0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jan 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.44.2` -> `v0.45.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.0...v0.45.1) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - Disable `layering_check` feature in CGo tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3829](https://togithub.com/bazelbuild/rules_go/pull/3829) - Print stack traces without panicking on test timeout by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3833](https://togithub.com/bazelbuild/rules_go/pull/3833) - Fix regression in empty `.go` file filtering for nogo by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3832](https://togithub.com/bazelbuild/rules_go/pull/3832) - release patch version 0.45.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3836](https://togithub.com/bazelbuild/rules_go/pull/3836) **Full Changelog**: bazel-contrib/rules_go@v0.45.0...v0.45.1 ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - nogo: use original source files instead of coverage-instrumented by [@​emmaxy](https://togithub.com/emmaxy) in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - Allow compilers to be overwritten in go_grpc_library() by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812) - update documentation for 0.44 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813) - Temporarily undo deprecation of `//proto:go_grpc` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818) - Rename bazel_features polyfill to prevent conflicts by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817) - Handle prerelease versions in polyfill by [@​illicitonion](https://togithub.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821) - Extend gomock to allow passing an source_importpath instead of library when operating in source mode by [@​therve](https://togithub.com/therve) in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) - Fix coverage collection with modified `COVERAGE_DIR` env variable by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820) - improving logging for subcommand failure by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824) - release rules go 0.45.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825) #### New Contributors - [@​emmaxy](https://togithub.com/emmaxy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - [@​therve](https://togithub.com/therve) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) **Full Changelog**: bazel-contrib/rules_go@v0.44.2...v0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
rickystewart
added a commit
to cockroachdb/rules_go
that referenced
this pull request
Mar 15, 2024
This reverts commit 55ea579.
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Mar 15, 2024
... to pull in `0e7e4e31aa49f1afbb402fbb4895f38bc702c88c`. See bazel-contrib/rules_go#3890 This reverts a change in bazel-contrib/rules_go#3824 which makes it much more difficult to see build errors. Epic: none Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Mar 15, 2024
120490: ui: show license expiration alert in Db Console r=koorosh a=koorosh With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire. This change doesn't affect clusters that doesn't have any license set. Release note (ui change): show alert message in Db Console when license is expired or close to expire. Depends on: #120475 Resolves: #98589 Epic: None Screens: 1. Less than 15 days before license expires <img width="1215" alt="Screenshot 2024-03-14 at 13 26 18" src="https://github.com/cockroachdb/cockroach/assets/3106437/54f18792-d16f-43d1-a439-bd04e7a91abd"> 2. License expired <img width="1215" alt="Screenshot 2024-03-14 at 13 25 26" src="https://github.com/cockroachdb/cockroach/assets/3106437/ec9b924a-7800-4cf9-a164-9f4f5b49e91f"> 3. License expired today <img width="1215" alt="Screenshot 2024-03-14 at 13 25 59" src="https://github.com/cockroachdb/cockroach/assets/3106437/38a29b0d-47c3-447a-beb5-d557b58bcfc9"> 120505: sql: deflake TestTrackOnlyUserOpenTransactionsAndActiveStatements r=rafiss a=rafiss This changes the test to block in AfterExecute rather than OnTxnFinish, which should make the active statements assertion less flaky. It also fixes a testing bug where the SELECT FOR UPDATE was not in a txn. fixes #120042 fixes #120235 fixes #119829 Release note: None 120547: ccl/cliccl: avoid opening Engine in debug encryption-decrypt r=sumeerbhola a=jbowens Adapt the `debug encryption-decrypt` command to avoid actually opening the Engine and instead only open the filesystem environment. This allows the command to be used even when missing or corrupt files prevent the Engine from being opened. Epic: none Fix #96699. Release note: none 120562: build: update `rules_go` r=jlinder a=rickystewart ... to pull in `0e7e4e31aa49f1afbb402fbb4895f38bc702c88c`. See bazel-contrib/rules_go#3890 This reverts a change in bazel-contrib/rules_go#3824 which makes it much more difficult to see build errors. Epic: none Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
linzhp
added a commit
to linzhp/rules_go
that referenced
this pull request
Mar 16, 2024
This reverts commit 55ea579.
fmeum
pushed a commit
to linzhp/rules_go
that referenced
this pull request
Mar 17, 2024
](https://renovatebot.com){kind=link}
This reverts commit 55ea579.
fmeum
pushed a commit
that referenced
this pull request
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing out the full command line args when a subcommand fails, so it's easier to debug.