Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching and viewing verified pub video doesn't show favicon in BR panel/a-c list #3404

Closed
srirambv opened this issue Feb 18, 2019 · 9 comments · Fixed by brave/brave-core#1790

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 18, 2019

Description

Searching and viewing verified pub video doesn't show favicon in BR panel/a-c list

Steps to Reproduce

  1. Enable rewards from BR panel
  2. Visit twitch.tv and search for neoness007 or ekan1975
  3. Watch any clips from either of the publisher
  4. Check BR panel/a-c list, publisher favicon is not shown on both locations

Actual result:

image
image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa @NejcZdovc
@GeetaSarvadnya was able to reproduce it on Windows 10 x64
Found while verifying #3324

@GeetaSarvadnya
Copy link

Reproducible on Windows 10 x64

A-C table - No favicon display for verified twitch pubs
image
BR Panel - No favicon display for verified twitch pubs

image

@LaurenWags
Copy link
Member

LaurenWags commented Feb 18, 2019

I searched for xondak and viewed a VOD and got his verified favicon - using:

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

screen shot 2019-02-18 at 1 28 22 pm

STR:
Go to twitch.tv/directory
Search for xondak
Click on his channel in the list
Click on videos near the top of the page
View a video
Click on panel.
Panel showed custom favicon, not generic twitch favicon.

@srirambv
Copy link
Contributor Author

I can still reproduce with neoness007 and ekan1975 but not for xondak on 0.60.40 RC build

@LaurenWags
Copy link
Member

Maybe related to #3044 ?

@LaurenWags
Copy link
Member

I can reproduce for neoness007 fairly consistently but not ekan1975:
screen shot 2019-02-19 at 5 32 39 pm

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

@kjozwiak
Copy link
Member

Ran into a similar issue when going through 0.60.44 Chromium: 72.0.3626.109.

Example of the issue occurring:

screen shot 2019-02-20 at 3 29 27 pm

Example of expected results:

screen shot 2019-02-20 at 3 33 45 pm

@NejcZdovc NejcZdovc self-assigned this Feb 27, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 27, 2019
@NejcZdovc
Copy link
Contributor

Note to the issue is that you need to open panel to get favicon. From just regular watching clips and live streams we don't get favicon. We only get it for VOD's

@GeetaSarvadnya
Copy link

Reproducible on Windows 10 x64 - 0.63.5

Brave 0.63.5 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 10 OS Build 17134.523

image

@LaurenWags
Copy link
Member

LaurenWags commented Mar 20, 2019

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Screen Shot 2019-03-20 at 2 17 12 PM

Screen Shot 2019-03-20 at 2 18 39 PM

Verification passed on

Brave 0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

image

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants