Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert groundtest to chisel3 #3048

Merged

Conversation

tianrui-wei
Copy link
Contributor

Convert groundtest subdirectory to chisel3

Signed-off-by: Tianrui Wei tianrui@tianruiwei.com

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

Convert groundtest subdirectory to chisel3

Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks

src/main/scala/groundtest/DummyPTW.scala Outdated Show resolved Hide resolved
src/main/scala/groundtest/DummyPTW.scala Outdated Show resolved Hide resolved
src/main/scala/groundtest/DummyPTW.scala Outdated Show resolved Hide resolved
src/main/scala/groundtest/TraceGen.scala Outdated Show resolved Hide resolved
src/main/scala/groundtest/TraceGen.scala Outdated Show resolved Hide resolved
src/main/scala/groundtest/TraceGen.scala Show resolved Hide resolved
@tianrui-wei
Copy link
Contributor Author

@sequencer Thank you for reviewing, the issues about is addressed

wrap io declaration and use explicit import

Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
@sequencer sequencer enabled auto-merge (squash) September 18, 2022 05:31
@tianrui-wei
Copy link
Contributor Author

Thanks for fixing the named param. The CI seems all good after your commit

@sequencer sequencer changed the base branch from master to chisel3_port September 24, 2022 13:41
@sequencer sequencer merged commit cc22d8a into chipsalliance:chisel3_port Oct 2, 2022
@sequencer sequencer mentioned this pull request Oct 2, 2022
sequencer added a commit that referenced this pull request Oct 3, 2022
feat: convert groundtest to chisel3
wrap io declaration and use explicit import

Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
SingularityKChen pushed a commit to SingularityKChen/rocket-chip that referenced this pull request Oct 3, 2022
feat: convert groundtest to chisel3
wrap io declaration and use explicit import

Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
sequencer added a commit that referenced this pull request Oct 4, 2022
* feat: convert groundtest to chisel3 (#3048)
* refactor util/package to chisel3. (#3050)
* refactor TLBPermissions to chisel3. (#3055)
* refactor ICache to chisel3. (#3064)
* refactor PTW to chisel3. (#3067)
* refactor CSR to chisel3. (#3068)
* refactor Timer to chisel3. (#3078)
* refactor DCache to chisel3. (#3077)

Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: SingularityKChen <chency_singularity@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants