-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert groundtest to chisel3 #3048
Merged
sequencer
merged 3 commits into
chipsalliance:chisel3_port
from
tianrui-wei:groundtest-chisel3
Oct 2, 2022
Merged
feat: convert groundtest to chisel3 #3048
sequencer
merged 3 commits into
chipsalliance:chisel3_port
from
tianrui-wei:groundtest-chisel3
Oct 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert groundtest subdirectory to chisel3 Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
sequencer
requested changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nitpicks
tianrui-wei
force-pushed
the
groundtest-chisel3
branch
from
September 14, 2022 21:55
2e7295a
to
7576016
Compare
@sequencer Thank you for reviewing, the issues about is addressed |
wrap io declaration and use explicit import Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
tianrui-wei
force-pushed
the
groundtest-chisel3
branch
from
September 15, 2022 23:20
7576016
to
503d3d4
Compare
sequencer
requested changes
Sep 18, 2022
Thanks for fixing the named param. The CI seems all good after your commit |
sequencer
approved these changes
Oct 2, 2022
Closed
sequencer
added a commit
that referenced
this pull request
Oct 3, 2022
feat: convert groundtest to chisel3 wrap io declaration and use explicit import Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com> Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
SingularityKChen
pushed a commit
to SingularityKChen/rocket-chip
that referenced
this pull request
Oct 3, 2022
feat: convert groundtest to chisel3 wrap io declaration and use explicit import Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com> Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
sequencer
added a commit
that referenced
this pull request
Oct 4, 2022
* feat: convert groundtest to chisel3 (#3048) * refactor util/package to chisel3. (#3050) * refactor TLBPermissions to chisel3. (#3055) * refactor ICache to chisel3. (#3064) * refactor PTW to chisel3. (#3067) * refactor CSR to chisel3. (#3068) * refactor Timer to chisel3. (#3078) * refactor DCache to chisel3. (#3077) Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com> Co-authored-by: Jiuyang Liu <liu@jiuyang.me> Co-authored-by: SingularityKChen <chency_singularity@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert groundtest subdirectory to chisel3
Signed-off-by: Tianrui Wei tianrui@tianruiwei.com
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes