docs(gas/fees): Update block gas documentation #20128

samricotta · 2024-04-22T10:06:32Z

Description

Updates the block gas documentation to be more explicit and remove some of the misapprehension on the current docs explained in the issue.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Documentation
- Updated information on gas consumption and block gas meter in the Cosmos SDK, including details on handling per block gas consumption and finite limits during transaction processing.

coderabbitai · 2024-04-22T10:06:39Z

Walkthrough

The recent update refines the Cosmos SDK documentation concerning block gas metering. It clarifies the points in the transaction lifecycle where gas is consumed and updates terminology from BeginBlock to FinalizeBlock, enhancing the accuracy and understanding of gas usage during transaction processing.

Changes

File Path	Change Summary
`docs/learn/beginner/.../04-gas-fees.md`	Updated handling of gas consumption and terminology in block gas metering.

Assessment against linked issues

Objective	Addressed	Explanation
Update block gas documentation (#17320)	✅
Specify exactly when baseapp consumes block gas (#17320)	❓	The documentation changes mention updates in terminology and process but do not explicitly detail each point where baseapp consumes block gas.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2645e1c and 9df6c3e.

Files selected for processing (1)

docs/learn/beginner/04-gas-fees.md (1 hunks)

Additional Context Used

LanguageTool (66)

docs/learn/beginner/04-gas-fees.md (66)

Near line 22: Please check whether ‘free’ might be the correct word here instead of ‘fee’.
Context: ...es). Still, most applications implement fee mechanisms to prevent spam by using th...

Near line 22: Possible spelling mistake found.
Context: ...mechanisms to prevent spam by using the AnteHandler. ## Gas Meter In the ...

Near line 26: Possible spelling mistake found.
Context: ...a gas meter. Gas meters implement the GasMeter interface ```go reference https://git...

Near line 34: This sentence does not start with an uppercase letter.
Context: ...#L40-L51 ``` where: * GasConsumed() returns the amount of gas that was consumed by ...

Near line 35: This sentence does not start with an uppercase letter.
Context: ...eter instance. * GasConsumedToLimit() returns the amount of gas that was consumed by ...

Near line 36: This sentence does not start with an uppercase letter.
Context: ...it if it is reached. * GasRemaining() returns the gas left in the GasMeter. * `Limit(...

Near line 36: Possible spelling mistake found.
Context: ...emaining()returns the gas left in the GasMeter. *Limit()` returns the limit of the g...

Near line 37: This sentence does not start with an uppercase letter.
Context: ...e gas left in the GasMeter. * Limit() returns the limit of the gas meter instance. `0...

Near line 38: This sentence does not start with an uppercase letter.
Context: ...sumeGas(amount Gas, descriptor string)consumes the amount ofgasprovided. If theg...

Near line 39: This sentence does not start with an uppercase letter.
Context: ...d goes above the limit. * RefundGas() deducts the given amount from the gas consumed....

Near line 39: Possible spelling mistake found.
Context: ...compatible chains can fully support the go-ethereum StateDB interface. * IsPastLimit() re...

Near line 39: Possible spelling mistake found.
Context: ...hains can fully support the go-ethereum StateDB interface. * IsPastLimit() returns `t...

Near line 40: This sentence does not start with an uppercase letter.
Context: ...um StateDB interface. * IsPastLimit() returns true if the amount of gas consumed by...

Near line 41: This sentence does not start with an uppercase letter.
Context: ...it, false otherwise. * IsOutOfGas() returns true if the amount of gas consumed by...

Near line 43: Possible spelling mistake found.
Context: ...se. The gas meter is generally held in ctx, and consu...

Near line 53: This sentence does not start with an uppercase letter.
Context: .... ### Main Gas Meter ctx.GasMeter() is the main gas meter of the application. ...

Near line 53: Possible spelling mistake found.
Context: ...n. The main gas meter is initialized in FinalizeBlock via setFinalizeBlockState, and then ...

Near line 53: Possible spelling mistake found.
Context: ...r is initialized in FinalizeBlock via setFinalizeBlockState, and then tracks gas consumption durin...

Near line 53: Possible spelling mistake found.
Context: ...ons, i.e. those originally triggered by [FinalizeBlock](../advanced/00-baseapp.md#finalizeblo...

Near line 53: Possible spelling mistake found.
Context: ...n gas meter must be set to 0 in the AnteHandler, so that it can track g...

Near line 55: Possible spelling mistake found.
Context: ...enerally by the module developer in the [BeginBlocker, EndBlocker](../../build/building-mo...

Near line 55: Possible spelling mistake found.
Context: ...odule developer in the [BeginBlocker, EndBlocker](../../build/building-modules/06-begin...

Near line 55: Possible spelling mistake found.
Context: ...s implemented in a special store called GasKv....

Near line 59: This sentence does not start with an uppercase letter.
Context: ... Block Gas Meter ctx.BlockGasMeter() is the gas meter used to track gas consump...

Near line 61: Possible spelling mistake. ‘initialisation’ is British English.
Context: ...consumption is unlimited to accommodate initialisation transactions. ```go app.finalizeBlock...

Near line 67: Possible spelling mistake found.
Context: ...ilitated by the consensus engine (e.g., CometBFT) calling the RequestFinalizeBlock fun...

Near line 67: Possible spelling mistake found.
Context: ...sus engine (e.g., CometBFT) calling the RequestFinalizeBlock function, which in turn triggers the S...

Near line 67: Possible spelling mistake found.
Context: ...ction, which in turn triggers the SDK's FinalizeBlock method. Within FinalizeBlock, `inter...

Near line 67: Possible spelling mistake found.
Context: ...he SDK's FinalizeBlock method. Within FinalizeBlock, internalFinalizeBlock is executed, ...

Near line 67: Possible spelling mistake found.
Context: ...eBlockmethod. WithinFinalizeBlock, internalFinalizeBlock` is executed, performing necessary stat...

Near line 67: Do not mix variants of the same word (‘initialise’ and ‘initialize’) within a single text.
Context: ...nction executions. The block gas meter, initialised each with a finite limit, is then incor...

Near line 69: Possible spelling mistake. ‘utilising’ is British English.
Context: ... at any point during their execution by utilising the ctx. This gas consumption primari...

Near line 69: Possible spelling mistake found.
Context: ...during their execution by utilising the ctx. This gas consumption primarily occurs...

Near line 69: Add a space between sentences.
Context: ...ng. The block gas meter, accessible via ctx.BlockGasMeter(), monitors the total gas usage within...

Near line 78: Possible spelling mistake found.
Context: ...n the block's consensus parameters. ## AnteHandler The AnteHandler is run for every tra...

Near line 80: Possible spelling mistake found.
Context: ...sensus parameters. ## AnteHandler The AnteHandler is run for every transaction during `C...

Near line 80: Possible spelling mistake found.
Context: ...eris run for every transaction duringCheckTxandFinalizeBlock`, before a Protobuf...

Near line 80: Possible spelling mistake found.
Context: ... every transaction during CheckTx and FinalizeBlock, before a Protobuf Msg service metho...

Near line 80: Possible spelling mistake found.
Context: ...CheckTx and FinalizeBlock, before a Protobuf Msg service method for each sdk.Msg...

Near line 80: Add a space between sentences.
Context: ... Protobuf Msg service method for each sdk.Msg in the transaction. The anteHandler ...

Near line 82: Possible spelling mistake found.
Context: ...ach sdk.Msg in the transaction. The anteHandler is not implemented in the core Cosmos S...

Near line 82: Possible missing comma found.
Context: ...s not implemented in the core Cosmos SDK but in a module. That said, most applicatio...

Near line 82: Possible spelling mistake found.
Context: ...sdk/tree/main/x/auth). Here is what the anteHandler is intended to do in a normal Cosmos S...

Near line 84: Possible spelling mistake found.
Context: ...fined in the module that implements the anteHandler, and they follow the transaction inter...

Near line 90: Possible spelling mistake found.
Context: ...module, the default transaction type is Tx: ```protobuf reference https://githu...

Near line 96: Possible spelling mistake found.
Context: ...hese signatures must be verified in the anteHandler. * During CheckTx, verify that the g...

Near line 97: Possible spelling mistake found.
Context: ...verified in the anteHandler. * During CheckTx, verify that the gas prices provided w...

Near line 97: Possible spelling mistake found.
Context: ...local to each full-node and used during CheckTx to discard transactions that do not pr...

Near line 97: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ...nsactions that do not provide a minimum amount of fees. This ensures that the mempool ...

Near line 97: Possible spelling mistake found.
Context: ...m amount of fees. This ensures that the mempool cannot be spammed with garbage transact...

Near line 98: Possible spelling mistake found.
Context: ...value is stored in a parameter calledGasWantedfor later use. * SetnewCtx.GasMeter`...

Near line 99: Add a space between sentences.
Context: ...called GasWanted for later use. * Set newCtx.GasMeter to 0, with a limit of GasWanted. **T...

Near line 99: Possible spelling mistake found.
Context: ...newCtx.GasMeter to 0, with a limit of GasWanted. This step is crucial, as it not o...

Near line 99: Add a space between sentences.
Context: ...not consume infinite gas, but also that ctx.GasMeter is reset in-between each transaction (...

Near line 99: Possible spelling mistake found.
Context: ... is reset in-between each transaction (ctxis set tonewCtxafteranteHandler`...

Near line 99: Possible spelling mistake found.
Context: ...tween each transaction (ctx is set to newCtx after anteHandler is run, and the `a...

Near line 99: Possible spelling mistake found.
Context: ...saction (ctx is set to newCtx after anteHandler is run, and the anteHandler is run e...

Near line 99: Possible spelling mistake found.
Context: ...txafteranteHandleris run, and theanteHandler` is run each time a transactions execut...

Near line 101: Possible spelling mistake found.
Context: ...ons executes). As explained above, the anteHandler returns a maximum limit of gas the t...

Near line 101: Possible missing comma found.
Context: ...gasthe transaction can consume during execution calledGasWanted`. The actual amount c...

Near line 101: Possible spelling mistake found.
Context: ...ion can consume during execution called GasWanted. The actual amount consumed in the end...

Near line 101: Possible spelling mistake found.
Context: ...ount consumed in the end is denominated GasUsed, and we must therefore have `GasUsed =...

Near line 101: Possible spelling mistake found.
Context: ...d GasUsed, and we must therefore have GasUsed =< GasWanted. Both GasWanted and `Ga...

Near line 101: Possible spelling mistake found.
Context: ...efore have GasUsed =< GasWanted. Both GasWanted and GasUsed are relayed to the under...

Near line 101: Possible spelling mistake found.
Context: ...sed =< GasWanted. Both GasWantedandGasUsed` are relayed to the underlying consensu...

Near line 101: Possible spelling mistake found.
Context: ...to the underlying consensus engine when [FinalizeBlock](../advanced/00-baseapp.md#finalizeblo...

Path-based Instructions (1)

docs/learn/beginner/04-gas-fees.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (3)

docs/learn/beginner/04-gas-fees.md (3)

59-63: The explanation of the block gas meter during the genesis phase is clear and aligns well with the PR objectives. However, please remove the trailing space on line 61.

67-69: The description of the transition from an infinite to a finite block gas meter post-genesis is detailed and informative, enhancing the understanding of its impact on transaction processing.

76-77: The code snippet and explanation on setting the block gas meter with a finite limit based on the block's consensus parameters are clear and effectively demonstrate the practical application.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

julienrbrt

If we kill the block gas meter (#19793), does it really make sense to update its docs? Or is it meant for backporting?

samricotta · 2024-04-22T10:30:33Z

For 0.50 definitely since it will still be effected. Also good to have for now since we havent made all the changes yet to remove gas meter

(cherry picked from commit 96c243e)

) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <mavis@crypto.com> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me> * fix resolve * align dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: Marko <marko@baricevic.me>

* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(store): add release date (cosmos#19797) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <mavis@crypto.com> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <marko@baricevic.me> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * Add changelog entry and mark v0.50.7-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: John Letey <j@letey.de> Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>

Update 04-gas-fees.md

9df6c3e

samricotta requested a review from a team as a code owner April 22, 2024 10:06

julienrbrt approved these changes Apr 22, 2024

View reviewed changes

samricotta added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Apr 22, 2024

tac0turtle approved these changes Apr 22, 2024

View reviewed changes

tac0turtle added this pull request to the merge queue Apr 22, 2024

Merged via the queue into main with commit 96c243e Apr 22, 2024
56 of 57 checks passed

tac0turtle deleted the sam/gas-docs branch April 22, 2024 11:00

mergify bot pushed a commit that referenced this pull request Apr 22, 2024

docs(gas/fees): Update block gas documentation (#20128)

866f48e

(cherry picked from commit 96c243e)

mergify bot mentioned this pull request Apr 22, 2024

docs(gas/fees): Update block gas documentation (backport #20128) #20131

Merged

12 tasks

julienrbrt pushed a commit that referenced this pull request Apr 22, 2024

docs(gas/fees): Update block gas documentation (backport #20128) (#20131

3437fd5

) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(gas/fees): Update block gas documentation #20128

docs(gas/fees): Update block gas documentation #20128

samricotta commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

julienrbrt left a comment

samricotta commented Apr 22, 2024

docs(gas/fees): Update block gas documentation #20128

docs(gas/fees): Update block gas documentation #20128

Conversation

samricotta commented Apr 22, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Apr 22, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

julienrbrt left a comment

Choose a reason for hiding this comment

samricotta commented Apr 22, 2024

samricotta commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)