Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trigger --edit with host select #2588

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix trigger --edit with host select #2588

merged 1 commit into from
Feb 28, 2018

Conversation

matthewrmshin
Copy link
Contributor

cylc trigger --edit broken if task's remote host setting is a host select command. (Sorry.) This change fixes it.

@matthewrmshin matthewrmshin added this to the next release milestone Feb 27, 2018
@matthewrmshin matthewrmshin self-assigned this Feb 27, 2018
hjoliver
hjoliver approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, tests as working.

sadielbartholomew
sadielbartholomew approved these changes Feb 28, 2018
View reviewed changes
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - sensible code & I get an ERROR: no job file after 10 seconds in the gcylc Command Output window on master for a suite including a task with a host-selection shell command, but no longer get this issue after the changes. Clever test idea!

@sadielbartholomew sadielbartholomew merged commit 4dbb6c3 into cylc:master Feb 28, 2018
@matthewrmshin matthewrmshin deleted the trigger-edit-host-select branch February 28, 2018 11:53
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 23, 2018
@matthewrmshin
Selected back port to 7.6.x
f0f3fbc 
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2603 Fix gui insert nested family
* cylc#2588 Fix trigger --edit with host select
* cylc#2585 Fix recovery of a failed host select command
* cylc#2574 Fix gscan host port range owner behaviour
@matthewrmshin matthewrmshin mentioned this pull request Mar 23, 2018
Merged
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 26, 2018
@matthewrmshin
Selected back port to 7.6.x
4207e09 
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2604 Lowercase for shell bool vars
* cylc#2603 Fix gui insert nested family
* cylc#2602 gcylc: prevent negative job progress
* cylc#2596 Fix ref by value of parameters with plus/minus
* cylc#2592 Permit syntax errors with trigger edits
* cylc#2588 Fix trigger --edit with host select
* cylc#2586 Fix gcylc zero division error from task mean elapsed time
* cylc#2585 Fix recovery of a failed host select command
* cylc#2579 Fix gscan exception hook dialog closure incapacity
* cylc#2574 Fix gscan host port range owner behaviour
* cylc#2571 gcylc: fix tailer of remote job log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
bug
Projects
None yet
Milestone
cylc-7.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @hjoliver @sadielbartholomew