Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase for shell bool vars. #2604

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Conversation

hjoliver
Copy link
Member

Just noticed in job.err files:

$ cylc cat-log -e foo foo.1
/home/vagrant/cylc.git/lib/cylc/job.sh: line 29: False: command not found

Due to use of Python str(bool) as a shell boolean, or testing of such a value in the job script - broken sometime since last release.

@hjoliver hjoliver added the bug Something is wrong :( label Mar 22, 2018
@hjoliver hjoliver added this to the next release milestone Mar 22, 2018
@hjoliver hjoliver self-assigned this Mar 22, 2018
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suitable fix & test.

@sadielbartholomew sadielbartholomew merged commit d2168ef into cylc:master Mar 22, 2018
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 26, 2018
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2604 Lowercase for shell bool vars
* cylc#2603 Fix gui insert nested family
* cylc#2602 gcylc: prevent negative job progress
* cylc#2596 Fix ref by value of parameters with plus/minus
* cylc#2592 Permit syntax errors with trigger edits
* cylc#2588 Fix trigger --edit with host select
* cylc#2586 Fix gcylc zero division error from task mean elapsed time
* cylc#2585 Fix recovery of a failed host select command
* cylc#2579 Fix gscan exception hook dialog closure incapacity
* cylc#2574 Fix gscan host port range owner behaviour
* cylc#2571 gcylc: fix tailer of remote job log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants