Permit syntax errors with trigger edits. #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(a couple of test failures need addressing) |
oliver-sanders
force-pushed
the
trigger-edit-syntax-error
branch
from
6c6ef49
to
ce8839a
Compare
hjoliver
approved these changes
Mar 12, 2018
lib/cylc/network/httpserver.py
Outdated
| """Prepare job file for a task. | ||
|
|
||
| items[0] is an identifier for matching a task proxy. | ||
| """ | ||
| self._check_access_priv_and_report(PRIV_FULL_CONTROL) | ||
| if not isinstance(items, list): | ||
| items = [items] | ||
| self.schd.command_queue.put(("dry_run_tasks", (items,), {})) | ||
| check_syntax = check_syntax in [True, 'True'] |
There was a problem hiding this comment.
Is there any need for this? The new arg doesn't come from user input or code.
There was a problem hiding this comment.
Everything gets "stringised" when its passed over the network interface. I've just remembered that matt changed these if in statements to literal_evals as a more elegant solution to the problem:
group_all = self._literal_eval('group_all', group_all)I'll amend the code to use this approach.
matthewrmshin
approved these changes
Mar 20, 2018
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Mar 26, 2018
* cylc#2606 Fix poll when job.status has no batch sys info * cylc#2604 Lowercase for shell bool vars * cylc#2603 Fix gui insert nested family * cylc#2602 gcylc: prevent negative job progress * cylc#2596 Fix ref by value of parameters with plus/minus * cylc#2592 Permit syntax errors with trigger edits * cylc#2588 Fix trigger --edit with host select * cylc#2586 Fix gcylc zero division error from task mean elapsed time * cylc#2585 Fix recovery of a failed host select command * cylc#2579 Fix gscan exception hook dialog closure incapacity * cylc#2574 Fix gscan host port range owner behaviour * cylc#2571 gcylc: fix tailer of remote job log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the cylc job file writer aborts on syntax error, this causes
cylc triggerto hang as no job file is written. This PR skips the syntax check for dry runs so that users can attempt to fix their scripts at runtime viacylc trigger --edit.Possibly related to reported intermittent hanging of
cylc trigger --edit.