Fix gui insert nested family #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewrmshin - can you explain how to reproduce the bug? I just tried inserting a nested family on current master, and it worked fine... |
|
I was shown the bug several times, but have not been able to reproduce it in a simple suite. I think I have patched the only place in the logic where the bug can be introduced. I'll ask the affected colleague to test it out at earliest opportunity. |
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Mar 23, 2018
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Mar 26, 2018
* cylc#2606 Fix poll when job.status has no batch sys info * cylc#2604 Lowercase for shell bool vars * cylc#2603 Fix gui insert nested family * cylc#2602 gcylc: prevent negative job progress * cylc#2596 Fix ref by value of parameters with plus/minus * cylc#2592 Permit syntax errors with trigger edits * cylc#2588 Fix trigger --edit with host select * cylc#2586 Fix gcylc zero division error from task mean elapsed time * cylc#2585 Fix recovery of a failed host select command * cylc#2579 Fix gscan exception hook dialog closure incapacity * cylc#2574 Fix gscan host port range owner behaviour * cylc#2571 gcylc: fix tailer of remote job log
hjoliver
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix the argument (which may end up with lots of
base:prefix) for inserting a family via the graph view.