Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make error on integration folder point to e2e #20853

Merged
merged 30 commits into from
Apr 15, 2022

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Mar 30, 2022

User facing changelog

The config errors now contain the exact testing type user should place the specPattern and excludeSpecPattern in

How has the user experience changed?

given the following set of mistakes

Invalid option used at the root of the object

export default {
  fixturesFolder: false,
  testFiles: 'cypress/integration/**/*.ts',
  e2e: {

  },
}

Invalid option used in a testing type

export default {
  fixturesFolder: false,
  e2e: {
    testFiles: 'cypress/integration/**/*.ts',
  },
}

Invalid option used in the setupNodeEvents function

export default {
  fixturesFolder: false,
  e2e: {
    setupNodeEvents(on, config){
      config.testFiles = "**/*.spec.{tsx,js}";

      return config
    }
  },
}

Before

User would always see this error and had to figure out where the error was and what to do about it.

Before 1-2

After

More context is provided with the errors thrown.

Root

Screen Shot 2022-04-11 at 10 23 16 AM

TestingType

Screen Shot 2022-04-11 at 10 26 02 AM

setupNodeEvents

Screen Shot 2022-04-11 at 10 27 26 AM

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 30, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 4, 2022



Test summary

4343 0 48 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 16262fe
Started Apr 15, 2022 7:05 PM
Ended Apr 15, 2022 7:19 PM
Duration 13:46 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart marked this pull request as ready for review April 11, 2022 15:43
@elevatebart elevatebart requested review from a team as code owners April 11, 2022 15:43
@elevatebart elevatebart requested review from jennifer-shehane, emilyrohrbough and estrada9166 and removed request for a team April 11, 2022 15:43
@jennifer-shehane jennifer-shehane removed request for a team and jennifer-shehane April 11, 2022 15:47
@elevatebart elevatebart requested a review from tgriesser as a code owner April 12, 2022 20:32
@lmiller1990 lmiller1990 self-requested a review April 13, 2022 05:32
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and great PR description. Would it be a lot of complexity to add something similar for integrationFolder, like "integrationFolder is now part of specPattern"?

@jennifer-shehane
Copy link
Member

I approved the updated percy snapshot. The other failing snapshots are flake.

@elevatebart
Copy link
Contributor Author

@jennifer-shehane do you need to also approve the PR ?
Should I consider that you did? Do you have remarks?

@flotwig flotwig requested review from ryanthemanuel and removed request for emilyrohrbough April 14, 2022 15:35
@elevatebart elevatebart merged commit 026c300 into 10.0-release Apr 15, 2022
@elevatebart elevatebart deleted the elevatebart/fix/plugins-config-error-text branch April 15, 2022 20:05
tgriesser added a commit that referenced this pull request Apr 20, 2022
…e-config

* 10.0-release:
  fix: make error on integration folder point to e2e (#20853)
  fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084)
  chore: fix windows node_modules install step (#21098)
  fix: webpack integration tests for app w webpack-dev-server-fresh (#21093)
  fix: move non spec files on migration (#21054)
  Bumping electron version in root
  chore(deps): Bumping electron dependency to 15.5.1 (#21072)
  fix: resolves correctly specPattern (#21057)
  feat: replace reconfigure button on settings page with link to config doc (#21077)
  feat(launchpad): update CT setup and config scaffolding (#20893)
  fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042)
  chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081)
  fix(cli): show additional mitigation steps for max path length error (#21047)
  fix: Plugin error when sending on disconnected IPC channel (#21011)
  chore: add internal types for cy.session command (#21028)
  chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants