feat: replace reconfigure button on settings page with link to config doc #21077
Conversation
|
Thanks for taking the time to open a PR!
|
|
Note: I haven't marked this for a release since it is not technically user-facing. This UI change is not considered user-facing since the UI it changes has not been released yet. Plz let me know if you think differently 😃 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
| @@ -50,4 +50,11 @@ describe('<SettingsContainer />', { viewportHeight: 800, viewportWidth: 900 }, ( | |||
|
|
|||
| cy.findByText(defaultMessages.settingsPage.projectId.title).should('not.exist') | |||
| }) | |||
|
|
|||
| it('renders footer with CTA button', () => { | |||
There was a problem hiding this comment.
I used a component test instead of an e2e test to get some experience with CT 😄 in general, when both approaches are equal, do we have a preference for one or the other?
There was a problem hiding this comment.
For verifying text content I prefer to keep it in the component tests.
There was a problem hiding this comment.
There are two PRs removing the ability to reconfigure a project, this one and #21063 @davidmunechika. There is some backend code that should be cleaned up as well since it's now dead code, I think it should be removed in one of these PRs (whichever gets merged last) or a ticket should be created and a fast follow.
| @@ -43,7 +43,7 @@ | |||
| variant="outline" | |||
There was a problem hiding this comment.
Above for the t('settingsPage.footer.text') should be modified to include the testing type since it's currently wired to only show component. Something like:
const footerText = computed(() => t('settingsPage.footer.text', { testingType: props.gql.currentProject?.currentTestingType === 'component' ? 'component' : 'E2E' }))
Then you can render {{ footerText }}
There was a problem hiding this comment.
Great callout!
Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
|
|
||
| it('renders footer with CTA button', () => { | ||
| mountSettingsContainer() | ||
| cy.contains('p', defaultMessages.settingsPage.footer.text) |
There was a problem hiding this comment.
| cy.contains('p', defaultMessages.settingsPage.footer.text) | |
| cy.contains('p', defaultMessages.settingsPage.footer.text.replace('{testingType}', 'E2E')) |
…e-config * 10.0-release: fix: make error on integration folder point to e2e (#20853) fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084) chore: fix windows node_modules install step (#21098) fix: webpack integration tests for app w webpack-dev-server-fresh (#21093) fix: move non spec files on migration (#21054) Bumping electron version in root chore(deps): Bumping electron dependency to 15.5.1 (#21072) fix: resolves correctly specPattern (#21057) feat: replace reconfigure button on settings page with link to config doc (#21077) feat(launchpad): update CT setup and config scaffolding (#20893) fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042) chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081) fix(cli): show additional mitigation steps for max path length error (#21047) fix: Plugin error when sending on disconnected IPC channel (#21011) chore: add internal types for cy.session command (#21028) chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
User facing changelog
n/a
Additional details
Since we have removed reconfiguring the testing type from the 10.0 release, the
Reconfigure Projectbutton in the Settings page should link to theConfiguration Guidein the Cypress docs instead.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?