Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev #21081

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

JessicaSachs
Copy link
Contributor

I changed the dependency on mount-utils from * to file:../mount-utils to fix what I thought was an issue with pulling in the right version of mount-utils.

This was originally introduced in a PR earlier today. For whatever reason, CI wasn't having these issues. 0e7b555

I'm going to try reverting the change back to "@cypress/mount-utils": "*".

image

@JessicaSachs JessicaSachs requested a review from a team as a code owner April 14, 2022 00:40
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 14, 2022

Thanks for taking the time to open a PR!

@lmiller1990
Copy link
Contributor

No dice

@tgriesser tgriesser changed the title chore: making the npm deps for vue, react, and vue2 use * chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev Apr 14, 2022
@cypress
Copy link

cypress bot commented Apr 14, 2022



Test summary

17872 0 217 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 2e378a5
Started Apr 14, 2022 1:52 PM
Ended Apr 14, 2022 2:06 PM
Duration 14:07 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
cypress/source_map_utils.cy.js Flakiness
1 driver/src/cypress/source_map_utils > .extractSourceMap > is performant with multiple source map comments in file

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser
Copy link
Member

Pretty sure we actually need to be using 0.0.0-development for local deps like this in the workspace. Updated to this and it looks like things are passing

@JessicaSachs JessicaSachs requested a review from a team as a code owner April 14, 2022 13:46
@JessicaSachs JessicaSachs requested review from jennifer-shehane and removed request for a team April 14, 2022 13:46
@flotwig flotwig requested a review from BlueWinds April 14, 2022 15:37
@tgriesser tgriesser merged commit 5615f79 into 10.0-release Apr 14, 2022
@tgriesser tgriesser deleted the chore/npm-deps-use-star branch April 14, 2022 16:57
tgriesser added a commit that referenced this pull request Apr 20, 2022
…e-config

* 10.0-release:
  fix: make error on integration folder point to e2e (#20853)
  fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084)
  chore: fix windows node_modules install step (#21098)
  fix: webpack integration tests for app w webpack-dev-server-fresh (#21093)
  fix: move non spec files on migration (#21054)
  Bumping electron version in root
  chore(deps): Bumping electron dependency to 15.5.1 (#21072)
  fix: resolves correctly specPattern (#21057)
  feat: replace reconfigure button on settings page with link to config doc (#21077)
  feat(launchpad): update CT setup and config scaffolding (#20893)
  fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042)
  chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081)
  fix(cli): show additional mitigation steps for max path length error (#21047)
  fix: Plugin error when sending on disconnected IPC channel (#21011)
  chore: add internal types for cy.session command (#21028)
  chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants