Added new storageclass for NFS support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
requested review from
abhi16394,
bharathsreekanth,
JacobGros,
mjsdell,
jooseppi-luna,
ashleyvjoy,
Deepak-Ghivari,
khareRajshree,
Prabhu-Dell and
VamsiSiddu-7
as code owners
|
Hi @KshitijaKakde, please update the target branch as nfs-support instead of main. Thanks. |
khareRajshree
requested changes
Apr 14, 2023
| # WaitForFirstConsumer: delay the binding and provisioning of PV until a pod using the PVC is created. | ||
| # Optional: false | ||
| # Default value: WaitForFirstConsumer (required for topology section below) | ||
| # nasName: NAS server's name. If not specified, value from secret.yaml will be used |
There was a problem hiding this comment.
Please add a new line before starting nasName section.
khareRajshree
requested changes
Apr 14, 2023
helm/csi-vxflexos/values.yaml
Outdated
| @@ -38,6 +38,11 @@ kubeletConfigDir: /var/lib/kubelet | |||
| # Default value: none | |||
| defaultFsType: ext4 | |||
|
|
|||
| # externalAccess: allows to specify additional entries for hostAccess of NFS volumes. Both single IP address and subnet are valid entries. | |||
There was a problem hiding this comment.
This line can be rephrased as: allows to specify additional entries for host to access NFS volumes.
JacobGros
reviewed
Apr 14, 2023
samples/config.yaml
Outdated
| @@ -24,6 +24,27 @@ | |||
| # defines the MDM(s) that SDC should register with on start. | |||
| # Allowed values: a list of IP addresses or hostnames separated by comma. | |||
| # Default value: none | |||
|
|
|||
There was a problem hiding this comment.
might be a good idea to include a line that nfs is only supported on arrays >= 4.0 here.
khareRajshree
approved these changes
Apr 17, 2023
VamsiSiddu-7
approved these changes
Apr 17, 2023
|
@KshitijaKakde Before merging the pr. Update this branch with the latest changes from nfs-support. |
|
Updated the PR with correct GitHub issue: dell/csm#763 |
VamsiSiddu-7
added a commit
that referenced
this pull request
Jul 20, 2023
* Add CheckNFS functionality to check the NFS support for given powerflex array. (#182) * Add checkNfs method. * add version check in checkNFS. * changed the nfs topology to true. * add debug. * add debug1. * add debug3. * removed the version logic. * add debug 4. * move logic to service.go * add debug 5 * add debug 6 * add debug 7. * add debug 8. * removed the debug logs. * unit test changes for nodeGetInfo. * updated go mod and go sum. * Added new storageclass for NFS support (#181) Added new storageclass for NFS support * helm chart update for nfs support (#183) * helm chart update for nfs support * Check nfs (#185) * Add checkNfs method. * Add helm tests for nfs feature (#188) * added helm tests for nfs. * fixed a small mistake in the 5vols-nfs test. * removed the ephemeral volume helm tests. * making one signed commit (#187) * Create NFS volume (#189) * create NFS volume implemented * Nfs controller publish Changes (#190) * indentation fixed for controller.yaml * NFS storage class yaml updated * create NFS volume implemented * go.mod and go.sum updated * update controller publish volume for nfs. * hardcoded volume name for testing. * add debug. * files updated * add debug. * removed debug statements * add debug. * fixed error. * fix the panic. * add debug. * fixed the nil panic. * fixed the nfs export. * fix nfs export error. * files updated * updated files. * files updated * removed debug logs. * remove debug logs. * add debug. * add debug. * add debug3. * fixed a mistake. * add debug. * fixed th idempotency. * remove debug logs. * removed the hardcoded name. * address review comments. --------- Co-authored-by: Khare <rajshree.khare@dell.com> * Update NodePublish Volume for nfs. (#193) * update nodeunpublish volume for nfs changes. (#211) * added delete filesystem support in deletevolume (#212) * controller unpublish changes added (#214) * update build_ubi_micro.sh to include nfs-utils. * fix lint and unit-test failures. * fixed the gosec failures. * fix replication unit test failure. * add unit tests for nfs. * fixed the unit test failure. * add induced errors to get handler. * add unit tests for delete control node publish unpublish fns. * fixed the unit test failures. * add more unit tests. * NFS: expand volume operation added (#216) * linting errors resolved * unit tests added for expand NFS volume * unit tests added for expand NFS volume * unit tests added for expand NFS volume * add more unit-test. * add more unit tests. * add more unit tests for coverage. * addressed review comments. --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Rajshree Khare <69839943+khareRajshree@users.noreply.github.com> Co-authored-by: ashleyvjoy <110008193+ashleyvjoy@users.noreply.github.com> Co-authored-by: Khare <rajshree.khare@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new storageclass for NFS support
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration