Merge Nfs-support branch into main #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex array. (#182) * Add checkNfs method. * add version check in checkNFS. * changed the nfs topology to true. * add debug. * add debug1. * add debug3. * removed the version logic. * add debug 4. * move logic to service.go * add debug 5 * add debug 6 * add debug 7. * add debug 8. * removed the debug logs. * unit test changes for nodeGetInfo. * updated go mod and go sum.
Added new storageclass for NFS support
* helm chart update for nfs support
* Add checkNfs method.
* added helm tests for nfs. * fixed a small mistake in the 5vols-nfs test. * removed the ephemeral volume helm tests.
* create NFS volume implemented
* indentation fixed for controller.yaml * NFS storage class yaml updated * create NFS volume implemented * go.mod and go.sum updated * update controller publish volume for nfs. * hardcoded volume name for testing. * add debug. * files updated * add debug. * removed debug statements * add debug. * fixed error. * fix the panic. * add debug. * fixed the nil panic. * fixed the nfs export. * fix nfs export error. * files updated * updated files. * files updated * removed debug logs. * remove debug logs. * add debug. * add debug. * add debug3. * fixed a mistake. * add debug. * fixed th idempotency. * remove debug logs. * removed the hardcoded name. * address review comments. --------- Co-authored-by: Khare <rajshree.khare@dell.com>
VamsiSiddu-7
requested review from
abhi16394,
bharathsreekanth,
JacobGros,
mjsdell,
jooseppi-luna,
ashleyvjoy,
Deepak-Ghivari,
khareRajshree,
KshitijaKakde,
Prabhu-Dell,
mbasha-dell and
kumarkgosa
as code owners
khareRajshree
requested changes
Jul 20, 2023
|
@khareRajshree I have Addressed your review comments. Can you please review it again .Thanks |
khareRajshree
approved these changes
Jul 20, 2023
ashleyvjoy
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr merges the nfs-support branch into main branch. The nfs-support branch contains the code changes for NFS create and delete feature into main branch
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration