Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nfs delete FileSystem #212

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Nfs delete FileSystem #212

merged 1 commit into from
Jun 27, 2023

Conversation

ashleyvjoy
Copy link
Collaborator

@ashleyvjoy ashleyvjoy commented Jun 27, 2023 •
edited
Loading

Description

Updated DeleteVolume to remove NFS Filesystems

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| (dell/csm#763) |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built the image, installed driver and triggered the volume deletion with nfs-changes. The file system was successfully removed from the array.
deletefslogs

@ashleyvjoy ashleyvjoy merged commit 3420779 into nfs-support Jun 27, 2023
KshitijaKakde pushed a commit that referenced this pull request Jun 27, 2023
@ashleyvjoy @KshitijaKakde
added delete filesystem support in deletevolume (#212)
1fe2594 
Signed-off-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
KshitijaKakde pushed a commit that referenced this pull request Jun 27, 2023
@ashleyvjoy @KshitijaKakde
added delete filesystem support in deletevolume (#212)
89b2923 
Signed-off-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
KshitijaKakde pushed a commit that referenced this pull request Jun 27, 2023
@ashleyvjoy @KshitijaKakde
added delete filesystem support in deletevolume (#212)
4c37675 
Signed-off-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
@ashleyvjoy ashleyvjoy deleted the deletenfs-fs branch July 3, 2023 11:27
VamsiSiddu-7 added a commit that referenced this pull request Jul 20, 2023
@VamsiSiddu-7 @KshitijaKakde
@khareRajshree @ashleyvjoy
Merge Nfs-support branch into main (#215)
e90fcab 
* Add CheckNFS functionality to check the NFS support for given powerflex array. (#182)

* Add checkNfs method.

* add version check in checkNFS.

* changed the nfs topology to true.

* add debug.

* add debug1.

* add debug3.

* removed the version logic.

* add debug 4.

* move logic to service.go

* add debug 5

* add debug 6

* add debug 7.

* add debug 8.

* removed the debug logs.

* unit test changes for nodeGetInfo.

* updated go mod and go sum.

* Added new storageclass for NFS support (#181)

Added new storageclass for NFS support

* helm chart update for nfs support (#183)

* helm chart update for nfs support

* Check nfs  (#185)

* Add checkNfs method.

* Add helm tests for nfs feature (#188)

* added helm tests for nfs.

* fixed a small mistake in the 5vols-nfs test.

* removed the ephemeral volume helm tests.

* making one signed commit (#187)

* Create NFS volume (#189)

* create NFS volume implemented

* Nfs controller publish Changes (#190)

* indentation fixed for controller.yaml

* NFS storage class yaml updated

* create NFS volume implemented

* go.mod and go.sum updated

* update controller publish volume for nfs.

* hardcoded volume name for testing.

* add debug.

* files updated

* add debug.

* removed debug statements

* add debug.

* fixed error.

* fix the panic.

* add debug.

* fixed the nil panic.

* fixed the nfs export.

* fix nfs export error.

* files updated

* updated files.

* files updated

* removed debug logs.

* remove debug logs.

* add debug.

* add debug.

* add debug3.

* fixed a mistake.

* add debug.

* fixed th idempotency.

* remove debug logs.

* removed the hardcoded name.

* address review comments.

---------

Co-authored-by: Khare <rajshree.khare@dell.com>

* Update NodePublish Volume for nfs. (#193)

* update nodeunpublish volume for nfs changes. (#211)

* added delete filesystem support in deletevolume (#212)

* controller unpublish changes added (#214)

* update build_ubi_micro.sh to include nfs-utils.

* fix lint and unit-test failures.

* fixed the gosec failures.

* fix replication unit test failure.

* add unit tests for nfs.

* fixed the unit test failure.

* add induced errors to get handler.

* add unit tests for delete control node publish unpublish fns.

* fixed the unit test failures.

* add more unit tests.

* NFS: expand volume operation added (#216)

* linting errors resolved

* unit tests added for expand NFS volume

* unit tests added for expand NFS volume

* unit tests added for expand NFS volume

* add more unit-test.

* add more unit tests.

* add more unit tests for coverage.

* addressed review comments.

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Rajshree Khare <69839943+khareRajshree@users.noreply.github.com>
Co-authored-by: ashleyvjoy <110008193+ashleyvjoy@users.noreply.github.com>
Co-authored-by: Khare <rajshree.khare@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KshitijaKakde KshitijaKakde KshitijaKakde approved these changes

@VamsiSiddu-7 VamsiSiddu-7 VamsiSiddu-7 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@JacobGros JacobGros Awaiting requested review from JacobGros

@mjsdell mjsdell Awaiting requested review from mjsdell

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@khareRajshree khareRajshree Awaiting requested review from khareRajshree

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyvjoy @VamsiSiddu-7 @KshitijaKakde