Nfs controller publish Changes #190

VamsiSiddu-7 · 2023-05-11T12:13:41Z

Description

This PR adds the support for nfs controller publish volume

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 90% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

I have Created a new image with the changes and installed the csi-powerflex driver
I have Executed helm test with volume creation and Controller publish of nfs,ext4,xfs volumes

…flex into nfs-control-pub-new

…nto nfs-control-pub-new

khareRajshree · 2023-05-12T07:03:58Z

service/controller.go

 				return nil, status.Error(codes.NotFound,
-					"volume not found")
+					"filesystem not found")


update the message wrt to volume, to keep the consistency throughout.

khareRajshree · 2023-05-12T07:04:15Z

service/controller.go

@@ -873,15 +891,22 @@ func (s *service) ControllerPublishVolume(
 		fsID := getFilesystemIDFromCsiVolumeID(csiVolID)
 		fs, err := s.getFilesystemByID(fsID, systemID)
 		if err != nil {
-			if strings.EqualFold(err.Error(), sioGatewayVolumeNotFound) || strings.Contains(err.Error(), "must be a hexadecimal number") {
+			if strings.EqualFold(err.Error(), sioGatewayFilesystemNotFound) || strings.Contains(err.Error(), "must be a hexadecimal number") {


update the error scenario wrt to volume, to keep the consistency throughout.

khareRajshree · 2023-05-12T07:04:20Z

service/controller.go

 			}
 			return nil, status.Errorf(codes.Internal,
-				"failure checking volume status before controller publish: %s",
+				"failure checking filesystem status before controller publish: %s",


update the message wrt to volume, to keep the consistency throughout.

khareRajshree · 2023-05-12T07:05:21Z

service/controller.go

@@ -95,6 +98,8 @@ const (
 	removeModeOnlyMe                    = "ONLY_ME"
 	sioGatewayNotFound                  = "Not found"
 	sioGatewayVolumeNotFound            = "Could not find the volume"
+	sioGatewayNFSExportNotFound         = "couldn't find NFS export"


If this error code is not being used, we can remove its instance from here.

VamsiSiddu-7 · 2023-05-12T07:25:25Z

Hi @khareRajshree I have addressed your review comments. please review it again Thanks

* Add CheckNFS functionality to check the NFS support for given powerflex array. (#182) * Add checkNfs method. * add version check in checkNFS. * changed the nfs topology to true. * add debug. * add debug1. * add debug3. * removed the version logic. * add debug 4. * move logic to service.go * add debug 5 * add debug 6 * add debug 7. * add debug 8. * removed the debug logs. * unit test changes for nodeGetInfo. * updated go mod and go sum. * Added new storageclass for NFS support (#181) Added new storageclass for NFS support * helm chart update for nfs support (#183) * helm chart update for nfs support * Check nfs (#185) * Add checkNfs method. * Add helm tests for nfs feature (#188) * added helm tests for nfs. * fixed a small mistake in the 5vols-nfs test. * removed the ephemeral volume helm tests. * making one signed commit (#187) * Create NFS volume (#189) * create NFS volume implemented * Nfs controller publish Changes (#190) * indentation fixed for controller.yaml * NFS storage class yaml updated * create NFS volume implemented * go.mod and go.sum updated * update controller publish volume for nfs. * hardcoded volume name for testing. * add debug. * files updated * add debug. * removed debug statements * add debug. * fixed error. * fix the panic. * add debug. * fixed the nil panic. * fixed the nfs export. * fix nfs export error. * files updated * updated files. * files updated * removed debug logs. * remove debug logs. * add debug. * add debug. * add debug3. * fixed a mistake. * add debug. * fixed th idempotency. * remove debug logs. * removed the hardcoded name. * address review comments. --------- Co-authored-by: Khare <rajshree.khare@dell.com> * Update NodePublish Volume for nfs. (#193) * update nodeunpublish volume for nfs changes. (#211) * added delete filesystem support in deletevolume (#212) * controller unpublish changes added (#214) * update build_ubi_micro.sh to include nfs-utils. * fix lint and unit-test failures. * fixed the gosec failures. * fix replication unit test failure. * add unit tests for nfs. * fixed the unit test failure. * add induced errors to get handler. * add unit tests for delete control node publish unpublish fns. * fixed the unit test failures. * add more unit tests. * NFS: expand volume operation added (#216) * linting errors resolved * unit tests added for expand NFS volume * unit tests added for expand NFS volume * unit tests added for expand NFS volume * add more unit-test. * add more unit tests. * add more unit tests for coverage. * addressed review comments. --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Rajshree Khare <69839943+khareRajshree@users.noreply.github.com> Co-authored-by: ashleyvjoy <110008193+ashleyvjoy@users.noreply.github.com> Co-authored-by: Khare <rajshree.khare@dell.com>

khareRajshree and others added 27 commits May 7, 2023 22:11

indentation fixed for controller.yaml

3bcd44b

NFS storage class yaml updated

39e88c6

create NFS volume implemented

e7304c8

go.mod and go.sum updated

45e9e5c

update controller publish volume for nfs.

d62f5a1

Merge branch 'nfs-create-volume' of https://github.com/dell/csi-power…

4178044

…flex into nfs-control-pub-new

hardcoded volume name for testing.

16731eb

add debug.

8134973

files updated

628f423

add debug.

c9e6068

Merge branch 'nfs-create-volume' of https://github.com/dell/csi-power…

7e56707

…flex into nfs-control-pub-new

removed debug statements

2d7fd6c

add debug.

cf0b1ea

fixed error.

3417c10

fix the panic.

7071293

add debug.

678d3de

fixed the nil panic.

46dba71

fixed the nfs export.

df0ed72

fix nfs export error.

3f6b779

files updated

e6a7083

Merge branch 'nfs-create-volume' of https://github.com/dell/csi-power…

065864b

…flex into nfs-control-pub-new

updated files.

8fbdd07

files updated

a0e9f92

Merge branch 'nfs-create-volume' of https://github.com/dell/csi-power…

2e5888a

…flex into nfs-control-pub-new

removed debug logs.

0bc1ba6

remove debug logs.

f004983

Merge branch 'nfs-support' of https://github.com/dell/csi-powerflex i…

2be908c

…nto nfs-control-pub-new

VamsiSiddu-7 requested review from abhi16394, bharathsreekanth and JacobGros as code owners May 11, 2023 12:13

VamsiSiddu-7 requested review from mjsdell, jooseppi-luna, ashleyvjoy, Deepak-Ghivari, khareRajshree, KshitijaKakde and Prabhu-Dell as code owners May 11, 2023 12:13

VamsiSiddu-7 added 8 commits May 11, 2023 11:06

add debug.

331a1c0

add debug.

3e3ea6c

add debug3.

c7ce0f5

fixed a mistake.

1ebf863

add debug.

850e772

fixed th idempotency.

ffd1a2a

remove debug logs.

1182759

removed the hardcoded name.

1d65ccd

khareRajshree requested changes May 12, 2023

View reviewed changes

address review comments.

e27b9d3

khareRajshree approved these changes May 12, 2023

View reviewed changes

KshitijaKakde approved these changes May 12, 2023

View reviewed changes

VamsiSiddu-7 merged commit 2492d61 into nfs-support May 12, 2023

VamsiSiddu-7 deleted the nfs-control-pub-new branch June 28, 2023 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nfs controller publish Changes #190

Nfs controller publish Changes #190

VamsiSiddu-7 commented May 11, 2023

khareRajshree May 12, 2023

VamsiSiddu-7 May 12, 2023

khareRajshree May 12, 2023

VamsiSiddu-7 May 12, 2023

khareRajshree May 12, 2023

VamsiSiddu-7 May 12, 2023

khareRajshree May 12, 2023

VamsiSiddu-7 May 12, 2023

VamsiSiddu-7 commented May 12, 2023

Nfs controller publish Changes #190

Nfs controller publish Changes #190

Conversation

VamsiSiddu-7 commented May 11, 2023

Description

GitHub Issues

Checklist:

How Has This Been Tested?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VamsiSiddu-7 commented May 12, 2023