VACMS-18855 Add Find Forms download modal back to form detail page #2239

randimays · 2024-08-14T18:37:50Z

Summary

In this PR we inadvertently removed the download modal from form detail pages. This PR plus its companion vets-website PR add that modal back and changes the links on the form detail page to buttons since they now trigger a modal.

Uses a feature toggle (FEATURE_FIND_FORMS_MODAL) to reduce risk on a paired deploy.

To run the build locally with the feature toggle on, point to this Tugboat in your .env: https://cms-ciyktotgoqohism0kiuuviu13oifigrz.demo.cms.va.gov/.

Related issue(s)

Find Forms: Add download modal on form detail pages va.gov-cms#18855

Testing done

See this vets-website PR for all testing specifics.

va-vfs-bot

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

src/site/layouts/va_form.drupal.liquid

eselkin

LGTM

chriskim2311

LGTM

randimays · 2024-09-06T19:24:27Z

src/site/components/va_related_form.drupal.liquid

@@ -0,0 +1,43 @@
+{% if vaForm.entity.entityUrl.path and vaForm.entity.entityPublished %}


Created to prevent code duplication for related forms. Previously, they always rendered a list even if there was only one related form. Now it's just a single div for one item and a list for multiple.

randimays · 2024-09-10T17:11:58Z

src/site/layouts/va_form.drupal.liquid

@@ -2,7 +2,7 @@
 {% include "src/site/includes/preview-edit.drupal.liquid" %}
 {% include "src/site/includes/breadcrumbs.drupal.liquid" %}

-<div id="content" class="interior">
+<div id="content">


This class and the data-testids in this file are not used

va-vfs-bot

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

src/site/components/va_related_form.drupal.liquid

src/site/layouts/va_form.drupal.liquid

chriskim2311

LGTM

eselkin

LGTM

* VACMS 17954 - remove italics from common conditions (#2238) * VACMS 17954 - remove italics * move to p instead of div * VACMS 16362: Make only published Vet Center Services display (#2243) * filterBy status:true services * fix accordion labeling ids * remove debugging * Adding arrow_circle_right to sprite sheet (#2244) * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * bump web-components (#2258) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-424 React SCO page to prod (#2253) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * direct links to hashreference of taxonomy name in facility (#2262) * VACMS 18711 - vet center banner image (#2251) * VC Banner image * Add entry for Benefit Eligibility Questionnaire (#2170) * update FMP name (#2257) Co-authored-by: Rachel <rachele.eiting@copilot.llc> * VACMS-18876 Fix breadcrumbs on checklist pages (#2266) * VEBT-468 remove 1990E from registry.json (#2260) * VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json * Add navigation svg icons to site/img directory (#2237) * adds svgs for nav icons * correct svg icon * remove custom event (#2263) * [ARF-87799] Remove 21a (#2269) [Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352) * #vebt-469 remove 1990s from registry.json (#2261) Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * add sign-in-changes app to registry (#2271) * Updating web-components version to latest (#2272) * wrapping (#2268) * #vebt-470 #removing 22-1990n entry in registry.json (#2264) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * #vebt-470 #removing 22-1990n entry in registry.json --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * VACMS-18855 Add Find Forms download modal back to form detail page (#2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Aaron Kriegler <159946297+vetskrieg@users.noreply.github.com> Co-authored-by: Rachel Eiting <reiting1@gmail.com> Co-authored-by: Rachel <rachele.eiting@copilot.llc> Co-authored-by: Randi Mays <randimays1024@gmail.com> Co-authored-by: Napoleon K. <95312667+GcioNapoleon@users.noreply.github.com> Co-authored-by: Ray Messina <48040208+rmessina1010@users.noreply.github.com> Co-authored-by: Oren Mittman <nihil2501@gmail.com> Co-authored-by: govcioChad <162637891+govcioChad@users.noreply.github.com> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> Co-authored-by: Alexander Garcia <67602137+asg5704@users.noreply.github.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>

randimays mentioned this pull request Aug 14, 2024

VACMS-18855 Add Find Forms download modal back to form detail page department-of-veterans-affairs/vets-website#31395

Merged

6 tasks

randimays force-pushed the 18855-find-forms-modal branch from 7961a94 to 6764949 Compare August 14, 2024 21:44

va-vfs-bot had a problem deploying to master/18855-find-forms-modal/18855-find-forms-modal August 14, 2024 21:56 Error

va-vfs-bot had a problem deploying to master/18855-find-forms-modal/18855-find-forms-modal August 15, 2024 21:59 Error

randimays marked this pull request as ready for review August 16, 2024 14:15

randimays requested a review from a team as a code owner August 16, 2024 14:15

va-vfs-bot requested a review from a team August 16, 2024 14:16

va-vfs-bot reviewed Aug 16, 2024

View reviewed changes

src/site/layouts/va_form.drupal.liquid Outdated Show resolved Hide resolved

src/site/layouts/va_form.drupal.liquid Outdated Show resolved Hide resolved

randimays marked this pull request as draft August 16, 2024 15:27

randimays marked this pull request as ready for review September 5, 2024 20:11

eselkin approved these changes Sep 5, 2024

View reviewed changes

chriskim2311 approved these changes Sep 5, 2024

View reviewed changes

randimays marked this pull request as draft September 5, 2024 21:14

randimays commented Sep 6, 2024

View reviewed changes

randimays force-pushed the 18855-find-forms-modal branch from db1d2f0 to 4129fab Compare September 6, 2024 19:30

va-vfs-bot temporarily deployed to master/18855-find-forms-modal/18855-find-forms-modal September 6, 2024 19:34 Inactive

va-vfs-bot temporarily deployed to master/18855-find-forms-modal/18855-find-forms-modal September 6, 2024 19:52 Inactive

randimays force-pushed the 18855-find-forms-modal branch from 4129fab to d0c99d4 Compare September 6, 2024 20:53

va-vfs-bot temporarily deployed to master/18855-find-forms-modal/18855-find-forms-modal September 6, 2024 20:59 Inactive

randimays force-pushed the 18855-find-forms-modal branch from d0c99d4 to ddf67d4 Compare September 10, 2024 17:11

randimays commented Sep 10, 2024

View reviewed changes

va-vfs-bot temporarily deployed to master/18855-find-forms-modal/18855-find-forms-modal September 10, 2024 17:33 Inactive

va-vfs-bot deployed to master/18855-find-forms-modal/18855-find-forms-modal September 10, 2024 21:06 View deployment

randimays marked this pull request as ready for review September 11, 2024 13:50

randimays requested review from a team as code owners September 11, 2024 13:50

va-vfs-bot reviewed Sep 11, 2024

View reviewed changes

src/site/components/va_related_form.drupal.liquid Show resolved Hide resolved

src/site/components/va_related_form.drupal.liquid Show resolved Hide resolved

src/site/layouts/va_form.drupal.liquid Show resolved Hide resolved

src/site/layouts/va_form.drupal.liquid Show resolved Hide resolved

randimays requested review from chriskim2311 and eselkin September 11, 2024 19:06

chriskim2311 approved these changes Sep 11, 2024

View reviewed changes

eselkin approved these changes Sep 11, 2024

View reviewed changes

platform-support-slack-integration bot mentioned this pull request Sep 12, 2024

I need a review for this PR please: https://github.com/depar... department-of-veterans-affairs/va.gov-team#92765

Closed

va-vfs-bot temporarily deployed to master/main/18855-find-forms-modal September 12, 2024 19:50 Inactive

randimays added 4 commits September 12, 2024 16:17

VACMS-18855 Add Find Forms download modal back to form detail page

c06de18

adding ID to container

b8a3310

Add feature flag

82e09a4

finishing up feature flag

77c7142

randimays force-pushed the 18855-find-forms-modal branch from 169d50b to 77c7142 Compare September 12, 2024 21:17

va-vfs-bot deployed to master/main/18855-find-forms-modal September 12, 2024 21:34 View deployment

randimays mentioned this pull request Sep 12, 2024

VACMS-18855 Add Find Forms download modal back to form detail page department-of-veterans-affairs/vets-website#31917

Merged

6 tasks

powellkerry approved these changes Sep 12, 2024

View reviewed changes

randimays merged commit fe16835 into main Sep 16, 2024
23 checks passed

randimays deleted the 18855-find-forms-modal branch September 16, 2024 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-18855 Add Find Forms download modal back to form detail page #2239

VACMS-18855 Add Find Forms download modal back to form detail page #2239

randimays commented Aug 14, 2024 •

edited

Loading

va-vfs-bot left a comment

eselkin left a comment

chriskim2311 left a comment

randimays Sep 6, 2024

randimays Sep 10, 2024

va-vfs-bot left a comment

chriskim2311 left a comment

eselkin left a comment

		@@ -0,0 +1,43 @@
		{% if vaForm.entity.entityUrl.path and vaForm.entity.entityPublished %}

VACMS-18855 Add Find Forms download modal back to form detail page #2239

VACMS-18855 Add Find Forms download modal back to form detail page #2239

Conversation

randimays commented Aug 14, 2024 • edited Loading

Summary

Related issue(s)

Testing done

va-vfs-bot left a comment

Choose a reason for hiding this comment

Icon found

What you can do

Note:

eselkin left a comment

Choose a reason for hiding this comment

chriskim2311 left a comment

Choose a reason for hiding this comment

randimays Sep 6, 2024

Choose a reason for hiding this comment

randimays Sep 10, 2024

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

Icon found

What you can do

Note:

chriskim2311 left a comment

Choose a reason for hiding this comment

eselkin left a comment

Choose a reason for hiding this comment

randimays commented Aug 14, 2024 •

edited

Loading