Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 13910 - Direct links to hash reference id in system Health Service list #2262

Merged

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Sep 4, 2024

Summary

  • Adds hash to open accordion at hash reference id of taxonomy name, when clicking on facility name from inside a system-level Health Service
  • Sitewide team

Related issue(s)

Testing done

  • Tested all facility service links on /pittsburgh-health-care/health-services/
  • Manually clicked on all links to determine if any would fail. The hash naming convention is the same for the id, so expected that it would not and confirmed.

Screenshots

PR's links on Health Service listings
First link clicked on Audiology and speech
Second link clicked

What areas of the site does it impact?

System Health Service List pages

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

Check on RI /pittsburgh-health-care/health-services/

@eselkin eselkin changed the title VACMS 13910 - Direct links to hash reference id of taxonomy name in facility from system Health Service list VACMS 13910 - Direct links to hash reference id in system Health Service list Sep 4, 2024
@eselkin eselkin marked this pull request as ready for review September 4, 2024 22:55
@eselkin eselkin requested a review from a team as a code owner September 4, 2024 22:55
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eselkin eselkin merged commit 9aa7235 into main Sep 5, 2024
26 checks passed
@eselkin eselkin deleted the VACMS-13910-HealthServices-link-directly-to-facility-service branch September 5, 2024 19:33
davidmpickett added a commit that referenced this pull request Sep 17, 2024
* VACMS 17954 - remove italics from common conditions (#2238)

* VACMS 17954 - remove italics
* move to p instead of div

* VACMS 16362: Make only published Vet Center Services display (#2243)

* filterBy status:true services
* fix accordion labeling ids
* remove debugging

* Adding arrow_circle_right to sprite sheet (#2244)

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>

* bump web-components (#2258)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* VEBT-424 React SCO page to prod (#2253)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>

* direct links to hashreference of taxonomy name in facility (#2262)

* VACMS 18711 - vet center banner image (#2251)

* VC Banner image

* Add entry for Benefit Eligibility Questionnaire (#2170)

* update FMP name (#2257)

Co-authored-by: Rachel <rachele.eiting@copilot.llc>

* VACMS-18876 Fix breadcrumbs on checklist pages (#2266)

* VEBT-468 remove 1990E from registry.json (#2260)

* VEBT-468 Remove 1990e from production.

* VEBT-468 remove 1990E from registry.json

* Add  navigation svg icons to site/img  directory (#2237)

* adds svgs for nav icons

* correct svg icon

* remove custom event (#2263)

* [ARF-87799] Remove 21a (#2269)

[Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352)

* #vebt-469 remove 1990s from registry.json (#2261)

Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com>

* add sign-in-changes app to registry (#2271)

* Updating web-components version to latest (#2272)

* wrapping (#2268)

* #vebt-470 #removing 22-1990n entry in registry.json (#2264)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* bump version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>

* #vebt-470 #removing 22-1990n entry in registry.json

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>
Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov>
Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com>

* VACMS-18855 Add Find Forms download modal back to form detail page (#2239)

* VACMS-18855 Add Find Forms download modal back to form detail page

* adding ID to container

* Add feature flag

* finishing up feature flag

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Eli Selkin <eli.selkin@agile6.com>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Kevin Duensing <kjduensing@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com>
Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov>
Co-authored-by: Aaron Kriegler <159946297+vetskrieg@users.noreply.github.com>
Co-authored-by: Rachel Eiting <reiting1@gmail.com>
Co-authored-by: Rachel <rachele.eiting@copilot.llc>
Co-authored-by: Randi Mays <randimays1024@gmail.com>
Co-authored-by: Napoleon K. <95312667+GcioNapoleon@users.noreply.github.com>
Co-authored-by: Ray Messina <48040208+rmessina1010@users.noreply.github.com>
Co-authored-by: Oren Mittman <nihil2501@gmail.com>
Co-authored-by: govcioChad <162637891+govcioChad@users.noreply.github.com>
Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com>
Co-authored-by: Alexander Garcia <67602137+asg5704@users.noreply.github.com>
Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants