-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS 13910 - Direct links to hash reference id in system Health Service list #2262
Merged
eselkin
merged 1 commit into
main
from
VACMS-13910-HealthServices-link-directly-to-facility-service
Sep 5, 2024
Merged
VACMS 13910 - Direct links to hash reference id in system Health Service list #2262
eselkin
merged 1 commit into
main
from
VACMS-13910-HealthServices-link-directly-to-facility-service
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eselkin
changed the title
VACMS 13910 - Direct links to hash reference id of taxonomy name in facility from system Health Service list
VACMS 13910 - Direct links to hash reference id in system Health Service list
Sep 4, 2024
randimays
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
chriskim2311
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eselkin
deleted the
VACMS-13910-HealthServices-link-directly-to-facility-service
branch
September 5, 2024 19:33
davidmpickett
added a commit
that referenced
this pull request
Sep 17, 2024
* VACMS 17954 - remove italics from common conditions (#2238) * VACMS 17954 - remove italics * move to p instead of div * VACMS 16362: Make only published Vet Center Services display (#2243) * filterBy status:true services * fix accordion labeling ids * remove debugging * Adding arrow_circle_right to sprite sheet (#2244) * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * bump web-components (#2258) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-424 React SCO page to prod (#2253) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * direct links to hashreference of taxonomy name in facility (#2262) * VACMS 18711 - vet center banner image (#2251) * VC Banner image * Add entry for Benefit Eligibility Questionnaire (#2170) * update FMP name (#2257) Co-authored-by: Rachel <rachele.eiting@copilot.llc> * VACMS-18876 Fix breadcrumbs on checklist pages (#2266) * VEBT-468 remove 1990E from registry.json (#2260) * VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json * Add navigation svg icons to site/img directory (#2237) * adds svgs for nav icons * correct svg icon * remove custom event (#2263) * [ARF-87799] Remove 21a (#2269) [Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352) * #vebt-469 remove 1990s from registry.json (#2261) Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * add sign-in-changes app to registry (#2271) * Updating web-components version to latest (#2272) * wrapping (#2268) * #vebt-470 #removing 22-1990n entry in registry.json (#2264) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * #vebt-470 #removing 22-1990n entry in registry.json --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * VACMS-18855 Add Find Forms download modal back to form detail page (#2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Aaron Kriegler <159946297+vetskrieg@users.noreply.github.com> Co-authored-by: Rachel Eiting <reiting1@gmail.com> Co-authored-by: Rachel <rachele.eiting@copilot.llc> Co-authored-by: Randi Mays <randimays1024@gmail.com> Co-authored-by: Napoleon K. <95312667+GcioNapoleon@users.noreply.github.com> Co-authored-by: Ray Messina <48040208+rmessina1010@users.noreply.github.com> Co-authored-by: Oren Mittman <nihil2501@gmail.com> Co-authored-by: govcioChad <162637891+govcioChad@users.noreply.github.com> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> Co-authored-by: Alexander Garcia <67602137+asg5704@users.noreply.github.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
/pittsburgh-health-care/health-services/
Screenshots
PR's links on Health Service listings
First link clicked on Audiology and speech
Second link clicked
What areas of the site does it impact?
System Health Service List pages
Acceptance criteria
If no Facilities offer that service... (should the System service even show?)- covered in Empty "Available at these locations" heading within a service accordion va.gov-cms#17165 (we chose not to do it?)Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Check on RI
/pittsburgh-health-care/health-services/