VACMS 18711 - vet center banner image #2251

eselkin · 2024-08-29T16:36:35Z

Summary

Adds media query to content-build for Banner image media for Vet Center. Currently this is the only media query outside of a node in the platform so it needs to get added into the node in metalsmith.
Sitewide team

Related issue(s)

FE: Display Vet Center Banner Image on Facility Pages va.gov-cms#18711

Testing done

Manually tested on Vet Center pages

Screenshots

Old Vet Center Desktop

New Vet Center Desktop

New Vet Center Desktop showing padding

New Vet Center mobile

What areas of the site does it impact?

Vet Center pages

Acceptance criteria

Create a GraphQL query to fetch the Vet Center banner image from the centralized content in Drupal. (No longer applicable)
Banner image is presented on Vet Center pages
Implement responsive breakpoints for the banner image (not using breakpoints, handled by img component controls of DST stylesheets)
Follow all annotations in linked Figma designs

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated (link to documentation *if necessary)
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

Check RI or tugboat
https://web-codylbelkq0gdivw6x7tykigmeqloewe.demo.cms.va.gov/boston-vet-center/

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/site/stages/update-vet-center-pages.js

eselkin · 2024-09-03T23:09:27Z

Seems debatable whether we need a picture > source > srcset instead of just an img tag, but since the original image is so small, it's likely just the one is good, unless we really need to conserve even more on mobile. It's just that a reduced-pixel image (400px instead of 1000px width) is still 47kb, so you only save 13 kb.

eselkin · 2024-09-04T18:08:40Z

@laflannery changes up on tugboat

laflannery · 2024-09-04T19:13:58Z

Looks good, approved!

randimays

LGTM!

eselkin · 2024-09-04T19:56:37Z

Re-running because something errored and it wouldn't just let me re-run failed

rmessina1010

LGTM

* VACMS 17954 - remove italics from common conditions (#2238) * VACMS 17954 - remove italics * move to p instead of div * VACMS 16362: Make only published Vet Center Services display (#2243) * filterBy status:true services * fix accordion labeling ids * remove debugging * Adding arrow_circle_right to sprite sheet (#2244) * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * bump web-components (#2258) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-424 React SCO page to prod (#2253) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * direct links to hashreference of taxonomy name in facility (#2262) * VACMS 18711 - vet center banner image (#2251) * VC Banner image * Add entry for Benefit Eligibility Questionnaire (#2170) * update FMP name (#2257) Co-authored-by: Rachel <rachele.eiting@copilot.llc> * VACMS-18876 Fix breadcrumbs on checklist pages (#2266) * VEBT-468 remove 1990E from registry.json (#2260) * VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json * Add navigation svg icons to site/img directory (#2237) * adds svgs for nav icons * correct svg icon * remove custom event (#2263) * [ARF-87799] Remove 21a (#2269) [Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352) * #vebt-469 remove 1990s from registry.json (#2261) Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * add sign-in-changes app to registry (#2271) * Updating web-components version to latest (#2272) * wrapping (#2268) * #vebt-470 #removing 22-1990n entry in registry.json (#2264) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * #vebt-470 #removing 22-1990n entry in registry.json --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * VACMS-18855 Add Find Forms download modal back to form detail page (#2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Aaron Kriegler <159946297+vetskrieg@users.noreply.github.com> Co-authored-by: Rachel Eiting <reiting1@gmail.com> Co-authored-by: Rachel <rachele.eiting@copilot.llc> Co-authored-by: Randi Mays <randimays1024@gmail.com> Co-authored-by: Napoleon K. <95312667+GcioNapoleon@users.noreply.github.com> Co-authored-by: Ray Messina <48040208+rmessina1010@users.noreply.github.com> Co-authored-by: Oren Mittman <nihil2501@gmail.com> Co-authored-by: govcioChad <162637891+govcioChad@users.noreply.github.com> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> Co-authored-by: Alexander Garcia <67602137+asg5704@users.noreply.github.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>

eselkin added 2 commits August 29, 2024 09:29

VC Banner image

2e20ca8

url

ea3ade1

eselkin changed the title ~~Vacms 18711 vet center banner image~~ VACMS 18711 - vet center banner image Aug 29, 2024

va-vfs-bot requested a review from a team August 29, 2024 16:37

va-vfs-bot reviewed Aug 29, 2024

View reviewed changes

src/site/stages/update-vet-center-pages.js Outdated Show resolved Hide resolved

va-vfs-bot temporarily deployed to master/main/VACMS-18711-VetCenter-Banner-Image August 29, 2024 16:45 Inactive

simplify

db6a68f

va-vfs-bot deployed to master/main/VACMS-18711-VetCenter-Banner-Image August 30, 2024 00:54 View deployment

eselkin added 2 commits September 3, 2024 12:15

image - hardcode

304e9aa

Merge branch 'main' into VACMS-18711-VetCenter-Banner-Image

57b2c4a

va-vfs-bot had a problem deploying to master/VACMS-18711-VetCenter-Banner-Image/VACMS-18711-VetCenter-Banner-Image September 3, 2024 19:58 Error

remove extra query

be39919

va-vfs-bot temporarily deployed to master/VACMS-18711-VetCenter-Banner-Image/VACMS-18711-VetCenter-Banner-Image September 3, 2024 22:35 Inactive

eselkin marked this pull request as ready for review September 3, 2024 23:21

eselkin requested review from a team as code owners September 3, 2024 23:21

eselkin added 2 commits September 4, 2024 09:16

no margin on img anyway

79c2f81

make shorter lines due to long alt text

6fba0c0

va-vfs-bot temporarily deployed to master/VACMS-18711-VetCenter-Banner-Image/VACMS-18711-VetCenter-Banner-Image September 4, 2024 16:52 Inactive

randimays approved these changes Sep 4, 2024

View reviewed changes

va-vfs-bot temporarily deployed to master/VACMS-18711-VetCenter-Banner-Image/VACMS-18711-VetCenter-Banner-Image September 4, 2024 20:02 Inactive

revert space changes

93eb820

va-vfs-bot deployed to master/VACMS-18711-VetCenter-Banner-Image/VACMS-18711-VetCenter-Banner-Image September 4, 2024 23:12 View deployment

platform-support-slack-integration bot mentioned this pull request Sep 5, 2024

Hi, I need a PR review of: https://github.com/department-of-... department-of-veterans-affairs/va.gov-team#92262

Closed

rmessina1010 approved these changes Sep 6, 2024

View reviewed changes

eselkin merged commit 1f36beb into main Sep 6, 2024
23 checks passed

eselkin deleted the VACMS-18711-VetCenter-Banner-Image branch September 6, 2024 00:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS 18711 - vet center banner image #2251

VACMS 18711 - vet center banner image #2251

eselkin commented Aug 29, 2024 •

edited

Loading

va-vfs-bot left a comment

eselkin commented Sep 3, 2024 •

edited

Loading

eselkin commented Sep 4, 2024

laflannery commented Sep 4, 2024

randimays left a comment

eselkin commented Sep 4, 2024

rmessina1010 left a comment

VACMS 18711 - vet center banner image #2251

VACMS 18711 - vet center banner image #2251

Conversation

eselkin commented Aug 29, 2024 • edited Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

eselkin commented Sep 3, 2024 • edited Loading

eselkin commented Sep 4, 2024

laflannery commented Sep 4, 2024

randimays left a comment

Choose a reason for hiding this comment

eselkin commented Sep 4, 2024

rmessina1010 left a comment

Choose a reason for hiding this comment

eselkin commented Aug 29, 2024 •

edited

Loading

eselkin commented Sep 3, 2024 •

edited

Loading