Release/2.17.0 #1339
Merged
Release/2.17.0 #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpl-form-number dataLayer event
…upport multiple on a page
…pc-sdp/ripple-framework into feature/SD-172-captcha-support
…ting form changes
[SD-274] update download attribute, add space between grant downloads
[SD-291] add aria label to vertical nav toggles
chore: update PR template
…red to be less finnicky
…eight feat: use prop value for map height
fix: removes unwanted internal: from URLs
fix: update tabs story so tabs can be clicked
[SD-257] - Added 'form start' analytics event
[SD-252] Back to top event
[SD-239] use dropdown labels, update search listing pii, track number input
# Conflicts: # packages/ripple-test-utils/step_definitions/common/navigation.ts
[SD-256] - Added form abandon event
[SD-251] publication events
[SD-172] Added support for CAPTCHAs in webforms
[SD-314] Breadcrumbs enhancement
[SD-353] add full stop to the end of sentence
[SD-207] Accordion slots
Update Nuxt to 2.13.2
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework
|
||||||||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
2.17.0
|
| Run status |
|
| Run duration | 09m 51s |
| Commit |
|
| Committer | Dylan Kelly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
200
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
test/features/maps/maps.feature • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Custom collection map component > Map can be viewed fullscreen |
Test Replay
Screenshots
|
|
waitingallday
approved these changes
Sep 26, 2024
jeffdowdle
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Checklist
For all PR's
For new components only