Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security·ts - dashboard feature controls dashboard security global dashboard & embeddable all privileges allow saving via the saved query management component popover with no query loaded

[kibanamachine]

A test failed on a tracked branch

        Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj~="saveQueryFormTitle"])
Wait timed out after 10059ms
    at /var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup3/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at lastError (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup3/node/linux-immutable/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup3/node/linux-immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)
    at lastError (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup3/node/linux-immutable/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup3/node/linux-immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)
      

First failure: Jenkins Build

[elasticmachine]

Pinging @elastic/kibana-test-triage

[elasticmachine]

Pinging @elastic/kibana-security

[spalger]

This is replicated in several places, so I'd rather not disable them all, can someone from @elastic/kibana-security please take a look?

[legrego]

Possibly related to #39140? -- @Bargs do you have any insights here? Looks like you graciously added this test, and the failure itself doesn't seem related to Security/Spaces/Feature Controls

[Bargs]

I'll take a look

[Bargs]

So it's failing because the save query modal hasn't opened up, even though the "Save current query" button was successfully clicked. Maybe it's just clicking the button before the popover component is fully rendered. I could add a retry that clicks it until the modal appears, but that might cover up a real issue. @spalger is there some way to capture the browser console output in a functional test so we could see if there's an error?

[spalger]

@Bargs the console output is included in the test log. Search for debg browser at https://kibana-ci.elastic.co/job/elastic+kibana+master/JOB=x-pack-ciGroup3,node=linux-immutable/70/testReport/junit/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_dashboard_feature_controls_dashboard_security·ts/dashboard_feature_controls_dashboard_security_global_dashboard___embeddable_all_privileges_allow_saving_via_the_saved_query_management_component_popover_with_no_query_loaded/

[Bargs]

Ah nice, thanks. I'm not seeing any errors so for now I'll try to fix this with a retry.

[kibanamachine]

New failure: Jenkins Build

[elasticmachine]

Pinging @elastic/kibana-app

[spalger]

@Bargs looks like there must be some other underlying issue here, the situation in #45317 looks very similar... not sure if that helps... @dmlemeshko do you think that any of the changes we've made to the driver could be interfering with click actions?

[spalger]

This has failed several times in PRs this week too

[flash1293]

For reference - this is also the problem in the other failures in Graph functional tests

The other failures from this batch are probably all the same underlying problem - e.g. #45105 (here the button to disable an aggregation wasn't actually clicked)

You can see the button being highlighted in all cases, but somehow the click is not processed. I could not reproduce this behavior locally.

Things in common:

• React is handling the click
• The elements are EUI buttons (specific html structure with nested spans inside of the button)
• They are all targeted with data-test-subj

[legrego]

hmm, the underlying root cause here might also be the cause of #44575. It looks like I'm missing a button click too...

[flash1293]

I wonder whether it's this thing:

I don't know how exactly selenium is clicking this button, but if you hover at the wrong place, you fall in and out of the clickable area because of the animation.

Maybe we should disable these things for the functional tests or make sure the button gets clicked in the center.

Related issue in EUI: elastic/eui#519

EDIT: It's probably not the cause, just noticed some of the failures also happen on non-animated buttons.

[spalger]

I don't know how exactly selenium is clicking this button, but if you hover at the wrong place, you fall in and out of the clickable area because of the animation.

It's unlikely that is causing the problem because the functional tests disable animations, but also in situations like that we should really be treating the unclickable region as a bug in the button I think.

It's totally reasonable to me that the element exists for a moment before it's clickable, though I'm not sure how it's rendered and if that's actually possible.

[spalger]

Related #45348

[flash1293]

It's totally reasonable to me that the element exists for a moment before it's clickable, though I'm not sure how it's rendered and if that's actually possible.

Not sure whether that’s the case here. I have to check to be 100% sure but some of the buttons have been around for some time before they are clicked.

[flash1293]

@LeeDr do you have an idea what the issue could be here? Seems to be something lowlevel.

[dmlemeshko]

do you think that any of the changes we've made to the driver could be interfering with click actions?

@spalger I doubt it is related to recent FTR changes: we added retry on error, but based on the logs it never retries. We still run Chrome tests the old way, so click is happening as before. But I noticed that we started to have an issue with selecting combobox with click action as I explained in #45751

[LeeDr]

It could be a similar problem to this issue;
"Discover New button takes forever or doesn't work" #45701

Fixed by;
"Fix scope digest issue with new button in discover" #45913

And/or this similar case (but I've only noticed this on IE);
"[IE11] several events aren't triggered until mouse moves off item" #45333

[Bargs]

I doubt it's a digest issue like #45701. All of these components are in React, and if it were digest related it would be easy to reproduce locally.

[kibanamachine]

New failure: Jenkins Build

[spalger]

Welp... Skipping again...

master: d7c36d0
7.x/7.7: cb3728d