-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [Case] Initial UI #57283
[SIEM] [Case] Initial UI #57283
Conversation
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/shared_imports.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/tag_list/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/tag_list/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/user_list/index.tsx
Show resolved
Hide resolved
...ins/siem/public/pages/detection_engine/rules/all/rules_table_filters/tags_filter_popover.tsx
Outdated
Show resolved
Hide resolved
...ins/siem/public/pages/detection_engine/rules/all/rules_table_filters/tags_filter_popover.tsx
Outdated
Show resolved
Hide resolved
} | ||
}, []); | ||
|
||
export const convertTagsToSet = (tagObjects: Array<SavedObject<CaseAttributes>>): Set<string> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit ->
export const convertTagsToSet = (tagObjects: object[]): Set<string> =>
tagObjects.reduce<Set<string>>((accum, tagObj) => {
if (isTags(tagObj)) {
tagObj.attributes.tags.forEach(accum.add, accum);
}
return accum;
}, new Set());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 💪 🚀 💪 🚀
Thank you for going over the code with me and keep me up to date with your code. This is really a nice jump to our case.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management homeStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
Summary
This is the initial UI for Case Workflows. Please note this is a work in progress and is UI development done before receiving the designs. Therefore, unit tests were not written as it is mostly all temporary. The only page that I've started matching up with the designs is the Case View. I need to PR so that @cnasikas and @XavierM can start to help turn this unruly beast into our MVP. This is highly incomplete. Here is what we're looking at...
All Cases View
There is some basic table functionality programmed here. Sorting on the Opened/Updated/State fields, pagination, etc. I'm not happy with how the table flashes between loads right now, that will be addressed.
@cnasikas helped out by implementing filtering by tags
I started to implement search. However, it's pretty buggy with saved objects. I'm just using the SO find with search: 'plain string'. Not specifying fields. However, it's just not picking up some searches. check out these inconsistencies. Sometimes it searches title, sometimes it does not.
Create new case
I've got a view to create a new case. Nothing too fancy here yet. I need to get our existing tags to autosuggest.
Case view
This is the one view I started matching up to Michael's design. If I add tests to this PR, it will be around this area. Here are the things that are working on this page:
Here are the things that do not yet work, most drop down options and email alerts:
Running the branch
Attention: Additional configuration is required to run this PR!! We are still using the legacy platform for Saved Object mappings, so a bit of weirdness needs to happen:
x-pack/legacy/plugins/siem/index.ts
- Add this value to the uiExports object beneath themappings
key:config/kibana.dev.yml
- Add the following lines to your dev.yml:x-pack/legacy/plugins/siem/public/pages/home/home_navigations.tsx
change line 58 to