[ML] New Platform server shim: update job service routes to use new platform router #57403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
78 tasks
darnautov
reviewed
Feb 12, 2020
darnautov
reviewed
Feb 12, 2020
x-pack/legacy/plugins/ml/server/new_platform/job_service_schema.ts
Outdated
Show resolved
Hide resolved
|
All comments have been addressed. Would you be up for a final look when you get a chance? cc @peteharverson, @jgowdyelastic, @darnautov |
|
I don't think this is directly related to this route, but I found another schema error, when editing the description of a detector in the edit modal of the Jobs list. I guess
Good spot @peteharverson - fixed in 007288a |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Feb 13, 2020
…latform router (elastic#57403) * wip: convert jobService route file to TS and use NP router * add schema definitions for route params * add api docs description for routes * update schema and rename client * update calendarManager * fix typo in schema * use NP context savedObjectsClient for rollup true * request no longer passed to JobServiceProvider * update anomalyDetectors schema for job update * add missing key to anomalydetectors schema
1 task
alvarezmelissa87
added a commit
that referenced
this pull request
Feb 13, 2020
… new platform router (#57403) (#57595) * [ML] New Platform server shim: update job service routes to use new platform router (#57403) * wip: convert jobService route file to TS and use NP router * add schema definitions for route params * add api docs description for routes * update schema and rename client * update calendarManager * fix typo in schema * use NP context savedObjectsClient for rollup true * request no longer passed to JobServiceProvider * update anomalyDetectors schema for job update * add missing key to anomalydetectors schema * update schema
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all job service routes to use new platform router.
Checklist
Delete any items that are not applicable to this PR.