-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle viewing sample dashboards on default dist #57510
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
Looks like I need to change the fix a bit;
|
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
LGTM ...locally tested by porting the changes- works good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ported the changes from these changed files to mine, and my tests work. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App changes LGTM.
* handle viewing sample dashboards on default dist * re-work change to not break jest test * Update snap for addition of data-test-subj
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
Summary
Fixes: #55795
Fixes sample data oss tests so they can launch the sample Dashboards regardless of an OSS or Default Dist build (including Cloud). The difference mainly being the View button in the sample data panels in OSS opens the dashboards directly because it's the only sample item. But on the default distribution there are other items that appear in a list so we have to select Dashboard for that method to work the same.
I used isOss, but in Kibana it's really "is there more than one item". So if we add some other sample data app to OSS, we'll have to fix this differently.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately