[compiler] Errors in earlier functions dont stop subsequent compilation #30844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
Aug 29, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: b8a8e6cfa8b99546b6e49f947596750688f168b1 Pull Request resolved: #30844
facebook-github-bot
added
CLA Signed
React Core Team
…t compilation" Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 29, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: a82cca9855adab77493e0a140d2a142788375d0d Pull Request resolved: #30844
josephsavona
commented
Aug 29, 2024
Comment on lines
+34
to
+45
| function ValidComponent(props) { | ||
| const $ = _c(2); | ||
| let t0; | ||
| if ($[0] !== props.greeting) { | ||
| t0 = <div>{props.greeting}</div>; | ||
| $[0] = props.greeting; | ||
| $[1] = t0; | ||
| } else { | ||
| t0 = $[1]; | ||
| } | ||
| return t0; | ||
| } |
There was a problem hiding this comment.
transformed despite the error in the component above
…t compilation" Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 29, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: 202b7f351ba79ddfcf865724a363c868e434598c Pull Request resolved: #30844
…t compilation" Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 29, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: 55363fd7b1a6921603ef3e63aeb558a679ec2b76 Pull Request resolved: #30844
…t compilation" Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 29, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: 8218c3a76eeab32bac5e1e6aba08cd40c66069c9 Pull Request resolved: #30844
mofeiZ
approved these changes
Aug 30, 2024
…t compilation" Errors in an earlier component/hook shouldn't stop later components from compiling. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 30, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: 6e04a5bb2e2045303cbddad6d6d4bd38d5f7990b Pull Request resolved: #30844
This was referenced Aug 30, 2024
nivemula
pushed a commit
to nivemula/Java
that referenced
this pull request
Sep 5, 2024
Errors in an earlier component/hook shouldn't stop later components from compiling. ghstack-source-id: 6e04a5bb2e2045303cbddad6d6d4bd38d5f7990b Pull Request resolved: facebook/react#30844
This was referenced Sep 5, 2024
This was referenced Sep 12, 2024
gnoff
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - facebook/react#30952 - facebook/react#30950 - facebook/react#30946 - facebook/react#30934 - facebook/react#30947 - facebook/react#30945 - facebook/react#30938 - facebook/react#30936 - facebook/react#30879 - facebook/react#30888 - facebook/react#30931 - facebook/react#30930 - facebook/react#30832 - facebook/react#30929 - facebook/react#30926 - facebook/react#30925 - facebook/react#30905 - facebook/react#30900 - facebook/react#30910 - facebook/react#30906 - facebook/react#30899 - facebook/react#30919 - facebook/react#30708 - facebook/react#30907 - facebook/react#30897 - facebook/react#30896 - facebook/react#30895 - facebook/react#30887 - facebook/react#30889 - facebook/react#30893 - facebook/react#30892 - facebook/react#30891 - facebook/react#30882 - facebook/react#30881 - facebook/react#30870 - facebook/react#30849 - facebook/react#30878 - facebook/react#30865 - facebook/react#30869 - facebook/react#30875 - facebook/react#30800 - facebook/react#30762 - facebook/react#30831 - facebook/react#30866 - facebook/react#30853 - facebook/react#30850 - facebook/react#30847 - facebook/react#30842 - facebook/react#30837 - facebook/react#30848 - facebook/react#30844 - facebook/react#30839 - facebook/react#30802 - facebook/react#30841 - facebook/react#30827 - facebook/react#30826 - facebook/react#30825 - facebook/react#30824 - facebook/react#30840 - facebook/react#30838 - facebook/react#30836 - facebook/react#30819 - facebook/react#30816 - facebook/react#30814 - facebook/react#30813 - facebook/react#30812 - facebook/react#30811 </details> --------- Co-authored-by: vercel-release-bot <infra+release@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Errors in an earlier component/hook shouldn't stop later components from compiling.