Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] Use RequestInstance constructor for resuming #30947

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sebmarkbage
Copy link
Collaborator

We added enough fields to need a constructor instead of inline object in V8.

We didn't update the resumeRequest path though so it wasn't using the constructor and had a different hidden class.

@sebmarkbage sebmarkbage requested a review from gnoff September 11, 2024 15:09
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:11pm

@react-sizebot
Copy link

Comparing: 344bc81...d9ae223

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 505.22 kB 505.22 kB = 90.29 kB 90.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 600.88 kB 600.88 kB = 106.29 kB 106.28 kB
facebook-www/ReactDOM-prod.modern.js = 577.17 kB 577.17 kB = 102.43 kB 102.43 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 245.69 kB 245.18 kB = 43.94 kB 43.78 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 250.21 kB 249.58 kB = 44.80 kB 44.70 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 244.58 kB 243.95 kB = 42.81 kB 42.71 kB
oss-experimental/react-server/cjs/react-server.development.js = 177.42 kB 176.71 kB = 31.49 kB 31.34 kB
oss-stable-rc/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-stable/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-experimental/react-server/cjs/react-server.production.js = 122.44 kB 121.76 kB = 21.73 kB 21.58 kB
oss-stable-rc/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB
oss-stable/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB

Generated by 🚫 dangerJS against 0e864ca

@sebmarkbage sebmarkbage merged commit 1bb0563 into facebook:main Sep 11, 2024
184 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
We added enough fields to need a constructor instead of inline object in
V8.

We didn't update the resumeRequest path though so it wasn't using the
constructor and had a different hidden class.

DiffTrain build for [1bb0563](1bb0563)
gnoff pushed a commit to vercel/next.js that referenced this pull request Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`**

[diff
facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d)

<details>
<summary>React upstream changes</summary>

- facebook/react#30952
- facebook/react#30950
- facebook/react#30946
- facebook/react#30934
- facebook/react#30947
- facebook/react#30945
- facebook/react#30938
- facebook/react#30936
- facebook/react#30879
- facebook/react#30888
- facebook/react#30931
- facebook/react#30930
- facebook/react#30832
- facebook/react#30929
- facebook/react#30926
- facebook/react#30925
- facebook/react#30905
- facebook/react#30900
- facebook/react#30910
- facebook/react#30906
- facebook/react#30899
- facebook/react#30919
- facebook/react#30708
- facebook/react#30907
- facebook/react#30897
- facebook/react#30896
- facebook/react#30895
- facebook/react#30887
- facebook/react#30889
- facebook/react#30893
- facebook/react#30892
- facebook/react#30891
- facebook/react#30882
- facebook/react#30881
- facebook/react#30870
- facebook/react#30849
- facebook/react#30878
- facebook/react#30865
- facebook/react#30869
- facebook/react#30875
- facebook/react#30800
- facebook/react#30762
- facebook/react#30831
- facebook/react#30866
- facebook/react#30853
- facebook/react#30850
- facebook/react#30847
- facebook/react#30842
- facebook/react#30837
- facebook/react#30848
- facebook/react#30844
- facebook/react#30839
- facebook/react#30802
- facebook/react#30841
- facebook/react#30827
- facebook/react#30826
- facebook/react#30825
- facebook/react#30824
- facebook/react#30840
- facebook/react#30838
- facebook/react#30836
- facebook/react#30819
- facebook/react#30816
- facebook/react#30814
- facebook/react#30813
- facebook/react#30812
- facebook/react#30811

</details>

---------

Co-authored-by: vercel-release-bot <infra+release@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants