firebase-dataconnect merge into main branch #6290

dconeybe · 2024-09-21T01:45:23Z

No description provided.

…ad of apply(from = "../gradle/googleServices.gradle")

…ing sent, but should have been sent as null (#550)

…that fail due to lack of null list support in the backend (b/337312723) (#552)

…with v1main, v1alpha, etc.

…arked as optional

…anged to required in the previous commit (d9da8a4)

…Test so that it passes consistently (#555)

…ypedDataIntegrationTest.kt

…uth emulator, since the auth emulator startup is slow

…alars.

…Manager" to just "QueryManager"

…taconnect:generateApiTxtFile

github-actions · 2024-09-21T01:45:35Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2024-09-21T01:45:35Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-09-21T01:46:05Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

github-actions · 2024-09-21T01:59:54Z

Unit Test Results

  1 046 files +  1 038   1 046 suites +1 038 37m 59s ⏱️ + 37m 31s
  5 710 tests +  5 688   5 688 ✔️ +  5 666 21 💤 +21 1 ❌ +1
12 123 runs +12 079 12 080 ✔️ +12 036 42 💤 +42 1 ❌ +1

For more details on these failures, see this check.

Results for commit 922c1df. ± Comparison against base commit da0eefa.

♻️ This comment has been updated with latest results.

google-oss-bot · 2024-09-21T02:19:40Z

Size Report ¹

Affected Products

firebase-common
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 4.40 MB 4.45 MB +46.9 kB (+1.1%)
firebase-common-ktx
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 4.40 MB 4.45 MB +46.9 kB (+1.1%)
firebase-database
Type Base (da0eefa) Merge (7e28684) Diff
aar 543 kB 542 kB -41 B (-0.0%)
apk (release) 5.29 MB 5.34 MB +47.1 kB (+0.9%)
firebase-database-ktx
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 5.29 MB 5.34 MB +47.1 kB (+0.9%)
firebase-dataconnect
Type Base (da0eefa) Merge (7e28684) Diff
aar ? 663 kB ? (?)
apk (aggressive) ? 520 kB ? (?)
apk (release) ? 11.0 MB ? (?)
firebase-firestore
Type Base (da0eefa) Merge (7e28684) Diff
aar 1.44 MB 1.44 MB +404 B (+0.0%)
apk (release) 11.3 MB 11.4 MB +47.1 kB (+0.4%)
firebase-firestore-ktx
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 11.3 MB 11.4 MB +47.1 kB (+0.4%)
firebase-storage
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 4.99 MB 5.04 MB +47.1 kB (+0.9%)
firebase-storage-ktx
Type Base (da0eefa) Merge (7e28684) Diff
apk (release) 4.99 MB 5.04 MB +47.1 kB (+0.9%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/UwAlxRyjbu.html

google-oss-bot · 2024-09-21T02:41:26Z

Coverage Report ¹

Affected Products

`firebase-config`

Overall coverage changed from ? (da0eefa) to 84.11% (7e28684) by ?.

33 individual files with coverage change

Filename	Base (`da0eefa`)	Merge (`7e28684`)	Diff
AutoValue_ConfigUpdate.java	?	29.41%	?
Code.java	?	0.00%	?
ConfigAutoFetch.java	?	87.74%	?
ConfigCacheClient.java	?	93.33%	?
ConfigContainer.java	?	94.29%	?
ConfigFetchHandler.java	?	92.86%	?
ConfigFetchHttpClient.java	?	87.33%	?
ConfigGetParameterHandler.java	?	96.45%	?
ConfigMetadataClient.java	?	92.31%	?
ConfigRealtimeHandler.java	?	41.38%	?
ConfigRealtimeHttpClient.java	?	68.93%	?
ConfigStorageClient.java	?	100.00%	?
ConfigUpdate.java	?	100.00%	?
ConfigUpdateListener.java	?	0.00%	?
ConfigUpdateListenerRegistration.java	?	0.00%	?
DefaultsXmlParser.java	?	0.00%	?
FirebaseRemoteConfig.java	?	89.52%	?
FirebaseRemoteConfigClientException.java	?	75.00%	?
FirebaseRemoteConfigException.java	?	95.65%	?
FirebaseRemoteConfigFetchThrottledException.java	?	100.00%	?
FirebaseRemoteConfigInfo.java	?	0.00%	?
FirebaseRemoteConfigInfoImpl.java	?	100.00%	?
FirebaseRemoteConfigServerException.java	?	68.42%	?
FirebaseRemoteConfigSettings.java	?	61.54%	?
FirebaseRemoteConfigValue.java	?	0.00%	?
FirebaseRemoteConfigValueImpl.java	?	84.62%	?
Personalization.java	?	91.43%	?
RemoteConfig.kt	?	31.58%	?
RemoteConfigComponent.java	?	90.70%	?
RemoteConfigConstants.java	?	0.00%	?
RemoteConfigRegistrar.java	?	100.00%	?
RolloutsStateFactory.java	?	95.24%	?
RolloutsStateSubscriptionsHandler.java	?	100.00%	?

firebase-database
Overall coverage changed from 50.16% (da0eefa) to 50.21% (7e28684) by +0.04%.
Filename Base (da0eefa) Merge (7e28684) Diff
ChildChangeAccumulator.java 83.33% 96.67% +13.33%

`firebase-dataconnect`

Overall coverage changed from ? (da0eefa) to 10.10% (7e28684) by ?.

47 individual files with coverage change

Filename	Base (`da0eefa`)	Merge (`7e28684`)	Diff
AnyValue.kt	?	0.00%	?
AnyValueSerializer.kt	?	0.00%	?
Comparisons.kt	?	0.00%	?
ConnectorConfig.kt	?	33.33%	?
CoroutineExceptionHandler.kt	?	50.00%	?
DataConnectAppCheck.kt	?	0.00%	?
DataConnectAuth.kt	?	0.00%	?
DataConnectCredentialsTokenManager.kt	?	0.00%	?
DataConnectError.kt	?	0.00%	?
DataConnectException.kt	?	0.00%	?
DataConnectGrpcClient.kt	?	0.00%	?
DataConnectGrpcMetadata.kt	?	65.82%	?
DataConnectGrpcRPCs.kt	?	0.00%	?
DataConnectSettings.kt	?	33.33%	?
DataConnectUntypedData.kt	?	0.00%	?
DataConnectUntypedVariables.kt	?	0.00%	?
DateSerializer.kt	?	0.00%	?
FirebaseDataConnect.kt	?	21.43%	?
FirebaseDataConnectFactory.kt	?	29.17%	?
FirebaseDataConnectImpl.kt	?	34.12%	?
FirebaseDataConnectRegistrar.kt	?	100.00%	?
GeneratedConnector.kt	?	0.00%	?
GeneratedMutation.kt	?	0.00%	?
GeneratedOperation.kt	?	0.00%	?
GeneratedQuery.kt	?	0.00%	?
LiveQueries.kt	?	0.00%	?
LiveQuery.kt	?	0.00%	?
Logger.kt	?	52.17%	?
LogLevel.kt	?	100.00%	?
MutationRef.kt	?	0.00%	?
MutationRefImpl.kt	?	21.95%	?
OperationRef.kt	?	0.00%	?
OperationRefImpl.kt	?	24.00%	?
OptionalVariable.kt	?	0.00%	?
ProtoStructDecoder.kt	?	0.00%	?
ProtoStructEncoder.kt	?	0.00%	?
ProtoUtil.kt	?	0.00%	?
QueryManager.kt	?	0.00%	?
QueryRef.kt	?	0.00%	?
QueryRefImpl.kt	?	23.53%	?
QuerySubscription.kt	?	0.00%	?
QuerySubscriptionImpl.kt	?	0.00%	?
QuerySubscriptionInternal.kt	?	0.00%	?
RegisteredDataDeserialzer.kt	?	0.00%	?
TimestampSerializer.kt	?	0.00%	?
Util.kt	?	6.96%	?
UUIDSerializer.kt	?	0.00%	?

firebase-firestore
Overall coverage changed from 46.06% (da0eefa) to 46.06% (7e28684) by +0.00%.
Filename Base (da0eefa) Merge (7e28684) Diff
SetMutation.java 94.44% 97.22% +2.78%
firebase-messaging
Overall coverage changed from 84.24% (da0eefa) to 84.17% (7e28684) by -0.07%.
Filename Base (da0eefa) Merge (7e28684) Diff
FirebaseMessaging.java 76.80% 76.00% -0.80%
firebase-ml-modeldownloader
Overall coverage changed from 83.32% (da0eefa) to 83.38% (7e28684) by +0.06%.
Filename Base (da0eefa) Merge (7e28684) Diff
FirebaseModelDownloader.java 84.05% 84.66% +0.61%
firebase-storage
Overall coverage changed from 84.33% (da0eefa) to 83.92% (7e28684) by -0.42%.
Filename Base (da0eefa) Merge (7e28684) Diff
StorageException.java 69.09% 65.45% -3.64%
StorageTask.java 83.99% 83.38% -0.60%
StreamDownloadTask.java 88.89% 88.41% -0.48%
UploadTask.java 83.17% 81.52% -1.65%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/r57CImhT3D.html

google-oss-bot · 2024-09-21T03:03:11Z

Startup Time Report ¹

The report is too large (122,625 chars) to be displayed on GitHub. Please check this report on GCS.

https://storage.googleapis.com/firebase-sdk-metric-reports/rPBtfokETm/index.html

dconeybe · 2024-09-21T03:30:42Z

@rlazo @daymxn The main files that need reviewing, IMO, are:

build.gradle
firebase-dataconnect/firebase-dataconnect.gradle.kts
gradle/libs.versions.toml
settings.gradle
subprojects.cfg

dconeybe added 30 commits April 25, 2024 01:26

Merge remote-tracking branch 'public/master' into dataconnect

f8cf2cb

firebase-dataconnect.gradle.kts: use id("copy-google-services") inste…

a085df6

…ad of apply(from = "../gradle/googleServices.gradle")

Add integration tests for "on" and "via" relations (#548)

552eb73

Merge remote-tracking branch 'public/master' into dataconnect

ea5691e

demo_ops.gql created by merging demo_foo_ops.gql and demo_scalar_ops.gql

5731997

gradle.properties: set version to 0.0.1-dev

f802fed

Logger.kt: include version in log messages

e695b85

Set version to 0.0.1 (#549)

58227ed

Set version to 0.0.2-dev

d31b005

ProtoStructEncoder.kt: fix bug where null variable values were not be…

9786180

…ing sent, but should have been sent as null (#550)

Merge remote-tracking branch 'public/master' into dataconnect

060f1df

TimestampSerializer.kt: fix and increase unit test coverage (#551)

53edd9b

DataConnectUntypedResponseIntegrationTest.kt: comment out test cases …

974ff02

…that fail due to lack of null list support in the backend (b/337312723) (#552)

Merge remote-tracking branch 'public/master' into dataconnect

c6a26ad

DataConnectGrpcClient.kt: include full RPC name in log message

bd9fd5e

Change directory and Java package of proto files, to avoid confusion …

155e672

…with v1main, v1alpha, etc.

demo_ops.gql: make query parameters required that were accidentally m…

d9da8a4

…arked as optional

Update generated code that was missed when optional variables were ch…

85a193c

…anged to required in the previous commit (d9da8a4)

Merge remote-tracking branch 'public/master' into dataconnect

d430d71

Change dependencies to public versions in gradle build scripts (#554)

f312a9a

upgrade firebase-auth dependency to the latest, 22.3.1 (was 20.0.0)

188af0e

Refactor data connect auth code, and, especially, fix AuthIntegration…

33064cd

…Test so that it passes consistently (#555)

Rename DataConnectUntypedResponseIntegrationTest.kt -> DataConnectUnt…

07b6368

…ypedDataIntegrationTest.kt

Update for UUID strings without dashes (#556)

acd6e7a

emulator.sh: provide an easy way to launch the emulator without the a…

96ce0fd

…uth emulator, since the auth emulator startup is slow

DataConnectSettings.kt: add STAGING_DATACONNECT_HOST

c34b0f9

DataConnectSettings.kt: AUTOPUSH_DATACONNECT_HOST added

4ca6482

DataConnectBackend.kt: added

28d9fe8

Add builder for variables to support optional variables (#553)

8760d4f

Merge remote-tracking branch 'public/master' into dataconnect

ceb98c1

dconeybe added 9 commits September 19, 2024 19:12

Merge remote-tracking branch 'origin/main' into dataconnect

ce7fb34

Overhaul AnyScalarIntegrationTest.kt (#6283)

22a34d1

gradleplugin: add support for 1.3.6 and 1.3.7

23cb8e2

Merge remote-tracking branch 'origin/main' into dataconnect

8d86ef2

gradleplugin: add support for 1.3.8, which fixes codegen for Any sc…

7b01d88

…alars.

Delete the "new" QueryManager, which was unused, and rename "OldQuery…

30c95d9

…Manager" to just "QueryManager"

updated firebase-dataconnect/api.txt by running ./gradlew firebase-da…

dd5a27b

…taconnect:generateApiTxtFile

AnyValue and AnyValueSerializer added (#6285)

146dbec

AnyScalarIntegrationTest.kt added (#6287)

fdb5019

dconeybe added the main-merge-ack label Sep 21, 2024

dconeybe self-assigned this Sep 21, 2024

google-oss-bot added the do-not-merge/work-in-progress label Sep 21, 2024

google-oss-bot added the size/XXL label Sep 21, 2024

dconeybe added 2 commits September 21, 2024 02:02

Fix syntax of CHANGELOG.md

e04ba3b

Merge branch 'main' into dataconnect

922c1df

dconeybe marked this pull request as ready for review September 21, 2024 03:30

google-oss-bot removed the do-not-merge/work-in-progress label Sep 21, 2024

dconeybe requested review from rlazo, maneesht, daymxn, cherylEnkidu and aashishpatil-g September 21, 2024 03:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

firebase-dataconnect merge into main branch #6290

firebase-dataconnect merge into main branch #6290

dconeybe commented Sep 21, 2024

github-actions bot commented Sep 21, 2024 •

edited

Loading

github-actions bot commented Sep 21, 2024

google-oss-bot commented Sep 21, 2024

github-actions bot commented Sep 21, 2024 •

edited

Loading

google-oss-bot commented Sep 21, 2024

`firebase-common`

`firebase-common-ktx`

`firebase-database`

`firebase-database-ktx`

`firebase-dataconnect`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-storage`

`firebase-storage-ktx`

google-oss-bot commented Sep 21, 2024

`firebase-config`

`firebase-database`

`firebase-dataconnect`

`firebase-firestore`

`firebase-messaging`

`firebase-ml-modeldownloader`

`firebase-storage`

google-oss-bot commented Sep 21, 2024

dconeybe commented Sep 21, 2024

firebase-dataconnect merge into main branch #6290

Are you sure you want to change the base?

firebase-dataconnect merge into main branch #6290

Conversation

dconeybe commented Sep 21, 2024

github-actions bot commented Sep 21, 2024 • edited Loading

📝 PRs merging into main branch

github-actions bot commented Sep 21, 2024

📝 PRs merging into main branch

google-oss-bot commented Sep 21, 2024

github-actions bot commented Sep 21, 2024 • edited Loading

Unit Test Results

google-oss-bot commented Sep 21, 2024

Size Report 1

Affected Products

firebase-common

firebase-common-ktx

firebase-database

firebase-database-ktx

firebase-dataconnect

firebase-firestore

firebase-firestore-ktx

firebase-storage

firebase-storage-ktx

Test Logs

google-oss-bot commented Sep 21, 2024

Coverage Report 1

Affected Products

firebase-config

firebase-database

firebase-dataconnect

firebase-firestore

firebase-messaging

firebase-ml-modeldownloader

firebase-storage

Test Logs

google-oss-bot commented Sep 21, 2024

Startup Time Report 1

dconeybe commented Sep 21, 2024

github-actions bot commented Sep 21, 2024 •

edited

Loading

github-actions bot commented Sep 21, 2024 •

edited

Loading

Size Report ¹

`firebase-common`

`firebase-common-ktx`

`firebase-database`

`firebase-database-ktx`

`firebase-dataconnect`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-storage`

`firebase-storage-ktx`

Coverage Report ¹

`firebase-config`

`firebase-database`

`firebase-dataconnect`

`firebase-firestore`

`firebase-messaging`

`firebase-ml-modeldownloader`

`firebase-storage`

Startup Time Report ¹