Check app start spans time and foreground state #3550

stefanosiano · 2024-07-04T14:52:42Z

📜 Description

App start now takes AppStartMetrics.appLaunchedInForeground variable in consideration when adding spans to the transaction. For some reason we were setting it, but never used it.
App starts longer than 1 minute are dropped (approach taken from Firebase)
Updated foreground app launch check, based on Firebase

💡 Motivation and Context

Should fix #3538 and #3329, implementing #3084

💚 How did you test it?

Unit tests

📝 Checklist

I reviewed the submitted code.
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…to add spans to the transaction App starts longer than 1 minute are dropped (same as Firebase)

github-actions · 2024-07-04T15:05:05Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	430.80 ms	494.08 ms	63.28 ms
Size	1.70 MiB	2.33 MiB	644.95 KiB

Previous results on branch: fix/app-start-foreground

Startup times

Revision	Plain	With Sentry	Diff
`e0d3b36`	420.52 ms	521.90 ms	101.37 ms
`e65564b`	410.64 ms	481.40 ms	70.76 ms
`99bdeb7`	404.61 ms	476.26 ms	71.65 ms
`09db9ad`	433.32 ms	494.82 ms	61.50 ms
`bcf684e`	406.80 ms	477.94 ms	71.14 ms
`331b61a`	441.43 ms	494.88 ms	53.45 ms
`2a3bf05`	377.29 ms	459.94 ms	82.65 ms
`715ec3c`	544.45 ms	626.55 ms	82.10 ms

App size

Revision	Plain	With Sentry	Diff
`e0d3b36`	1.70 MiB	2.33 MiB	644.95 KiB
`e65564b`	1.70 MiB	2.28 MiB	593.57 KiB
`99bdeb7`	1.70 MiB	2.28 MiB	593.89 KiB
`09db9ad`	1.70 MiB	2.28 MiB	594.01 KiB
`bcf684e`	1.70 MiB	2.28 MiB	594.07 KiB
`331b61a`	1.70 MiB	2.28 MiB	593.57 KiB
`2a3bf05`	1.70 MiB	2.28 MiB	593.69 KiB
`715ec3c`	1.70 MiB	2.28 MiB	593.89 KiB

added tests

markushi

Nice! If left one comment about uptime vs. unix time that should be addressed, but apart from that LGTM!

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

sentry-android-core/src/main/java/io/sentry/android/core/ContextUtils.java

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

…foreground status updated tests

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

added app launch foreground check to AppStartMetrics ctor

…yPerformanceProvider, other than AppStartMetrics.onApplicationCreate

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

kahest · 2024-07-11T15:05:08Z

@stefanosiano would be good to test if the scenario in #3567 is also fixed:

reproduce it if a push notification is received and the app is opened after some time(minutes or hours).

added foreground check to SentryAndroid.init

romtsn

LGTM!

# Conflicts: # CHANGELOG.md # sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidTest.kt

…ate instead of class instantiation AppStartMetrics callback is now registered only once AppStartMetrics stops app start profiler if no activity is being created

CHANGELOG.md

Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>

* Bump reactivecircus/android-emulator-runner from 2.30.1 to 2.31.0 (#3530) Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.30.1 to 2.31.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@6b0df4b...77986be) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump codecov/codecov-action from 4.3.1 to 4.5.0 (#3533) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@5ecb98a...e28ff12) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefano <stefano.siano@sentry.io> * [SR] Session Replay (#3339) * Add new sentry-android-replay module * Add screenshot recorder * Add sentry replay envelope and event * Add TODOs and license headers * Api dump * Formatting * Lint * Format code * More comments * Disable detekt plugin for now * WIP * Add replay envelopes * Remove jsonValue * Remove * Fix json * Finalize replay envelopes * Introduce MapObjectReader * Add missing test * Add test for MapObjectReader * Add MapObjectWriter change * Add finals * Fix test * Fix test * Address review * Add finals and annotations * Specify SHA for license headers * Address review from Dhiogo * Address review from Markus * Remove public captureReplay method * Fix test * api dump * api dump * Address review from Markus * Api dump * Add replay integration * Uncomment redacting * Update proguard rules * Add missing rule for AndroidTest * Add ReplayCache tests * Add tests * Add SessionReplayOptions * Call listeners when installing RootViewsSpy * Call listeners when installing RootViewsSpy * SessionReplayOptions -> SentryReplayOptions * Fix test * Add AndroidManifest options for replays * Add buffer mode and link replays with events/transactions * Pass hint to captureReplay * Better error handling * recycler lastScreenshot before re-assigning * Expose ReplayCache as public api * Fix redacting out of sync * _experimental -> experimental * Merge conflicts * Fix tests * Add more tests * Improve ReplayCache logic * frameUsec -> frameDurationUsec * bottom/right -> height/width * add todos * duration -> durationMs * replaId non-nullable * More conflicts * More conflicts * Fix tests * Address PR review * Add kdoc * Add kdoc * Fix tests * Add comment for experimental options * Do not run recorder if full session was not sampled * Add more tests * Add session deadline of 1h * Clean up older replays when starting a new one * Remove unnecessary extension fun * Safe executors * Fix crashing MediaCodec and use density to determine recording resolution * Add redact options and align naming * Fix tests * Fix tests * WIP * Try-catch release of encoder * Support orientation change for session mode * WIP * Spotless * TODO * Update sentry/src/main/java/io/sentry/SentryReplayOptions.java Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * More gates * Revert addAll * Fix conflicts * fix test * release: 7.8.0-alpha.0 * Introduce CaptureStrategy for buffer and session modes * Formatting * WIP * Expose public API for flutter * Spotless * Spotless * Remove breadcrumb import * Send temporary breadcrumbs and add test * Formatting * Sort rrweb events * Formatting * Expose replayCacheDir * Capture network requests * Change op name to resource.http * feat(replay): Add `sendReplay` method for Hybrid SDKs * fix apiDump * Address PR review * Capture motion events as incremental rrweb events * Spotless * Revert * Changelog * release: 7.9.0-alpha.1 * Fix test * WIP * Adhere to rrweb move event expectations * formatting * Align breadcrumbs with frontend and iOS * Add tests and fix deserialization * Rotate buffered motion events in buffer mode * Add Nullables * Address PR feedback * Formatting * Rotate current events until segment end exclusively * Allow rrweb breadcrumb customization from hybrid SDKs * Fix proguard rules * WIP * Add tests * Detect obscured views * revert some thigns * Remove commented code * Suppress lint * Support multi-touch gestures * Address PR feedback * Changelog * release: 7.11.0-alpha.2 * Make multi-touch work * Fix tests * WIP * Capture screen names as urls for replay * Fix * Ignore warning * Address PR feedback * Tests * Add quality settings * Fix redacting out of sync * Remove time measuring * Mark isEnableScreenTracking as experimental * Format code * Address PR feedback * Clean up * Spotless * Format code * Changelog * release: 7.12.0-alpha.3 * [SR] Add `redactClasses` option (#3546) Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> * misc(changelog): Prepare for next alpha * fix(changelog): Bump alpha version number * release: 7.12.0-alpha.4 * Redaction fixes for RN * Add stopgap for offline session recording * Recycle unused bitmap * Add tests for sentry * Add ReplayIntegrationTest * Replay SmokeTest * Fix test * Fix test * Fix events linking with buffered replays * Changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Krystof Woldrich <krystof.woldrich@sentry.io> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * release: 7.12.0 * Bump github/codeql-action from 3.25.10 to 3.25.11 (#3529) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@23acc5c...b611370) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump JamesIves/github-pages-deploy-action from 4.5.0 to 4.6.1 (#3531) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.5.0 to 4.6.1. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@65b5dfd...5c6e9e9) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump gradle/actions (#3532) Bumps [gradle/actions](https://github.com/gradle/actions) from 2cd2a6e951bd0b53f55a08e4e4c6f2586f3a36b9 to cdbbabd09cff07936e1c9dbe8c9d4b6ac2ef7156. - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@2cd2a6e...cdbbabd) --- updated-dependencies: - dependency-name: gradle/actions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add sentry-android-replay module to craft and readme (#3578) * Check app start spans time and foreground state (#3550) * App start now takes AppStartMetrics.appLaunchedInForeground variable to add spans to the transaction * App starts longer than 1 minute are dropped (same as Firebase) * added Activity lifecycle registration to check start launch time and foreground status * added AppStartMetrics.registerApplicationForegroundCheck in the SentryPerformanceProvider and SentryAndroid.init, other than AppStartMetrics.onApplicationCreate * ActivityLifecycleIntegration now reads first activity creation on create instead of class instantiation * AppStartMetrics stops app start profiler if no activity is being created * release: 7.12.1 * Bump github/codeql-action from 3.25.11 to 3.25.13 (#3591) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump reactivecircus/android-emulator-runner from 2.31.0 to 2.32.0 (#3573) Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.31.0 to 2.32.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@77986be...f0d1ed2) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump JamesIves/github-pages-deploy-action from 4.6.1 to 4.6.3 (#3590) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.1 to 4.6.3. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@5c6e9e9...94f3c65) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump gradle/actions (#3597) Bumps [gradle/actions](https://github.com/gradle/actions) from cdbbabd09cff07936e1c9dbe8c9d4b6ac2ef7156 to fd87365911aa12c016c307ea21313f351dc53551. - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@cdbbabd...fd87365) --- updated-dependencies: - dependency-name: gradle/actions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump gradle/wrapper-validation-action from 3.4.2 to 3.5.0 (#3589) Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/gradle/wrapper-validation-action/releases) - [Commits](gradle/wrapper-validation-action@8842585...f9c9c57) --- updated-dependencies: - dependency-name: gradle/wrapper-validation-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Spring Boot to 3.3.2 (#3541) * Bump Spring Boot to 3.3.1 * changelog * add specific classpath dependency for commons compress * bump to latest patch release of spring boot --------- Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com> * [SR] Capture Replays for ANRs and crashes (#3565) * release: 7.13.0 * Fix lazy select queries instrumentation (#3604) * added SentryCrossProcessCursor wrapper * SQLiteSpanManager now wraps CrossProcessCursors to start a span only when the cursor is filled with data * Avoid ArrayIndexOutOfBoundsException on Android cpu data collection (#3598) * added ArrayIndexOutOfBoundsException to try catch block in AndroidCpuCollector * [SR] ANR with buffered Replay integration test (#3612) * [SR] Buffer mode improvements (#3622) * Persist buffer replay type when switching to session * Ensure no gaps in segment timestamps when converting strategies * Properly store screen name at start for buffer mode * Changelog * [SR] Gesture/touch support for Flutter (#3623) * Persist buffer replay type when switching to session * Ensure no gaps in segment timestamps when converting strategies * Properly store screen name at start for buffer mode * Changelog * Decouple gesture tracking from WindowRecorder * Format code * Add tests * Changelog * Fix app start spans missing from Pixel devices (#3634) * added post on main thread to post check on main thread * [SR] Fix Session Replay crashes (#3628) * release: 7.14.0 * Verify sentry-android-replay for Google Play SDK Console (#3651) * Add verification file for Play Console * Update Changelog * Update Changelog * [SR] Rename errorSampleRate to onErrorSampleRate (#3637) * Rename errorSampleRate to onErrorSampleRate * pr id * Avoid stopping appStartProfiler after application creation (#3630) * AppStartMetrics stops appStartProfiler only if no activity ever started * Bump JamesIves/github-pages-deploy-action from 4.6.3 to 4.6.4 (#3681) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.3 to 4.6.4. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@94f3c65...920cbb3) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 3.25.13 to 3.26.6 (#3672) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.13 to 3.26.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@2d79040...4dd1613) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [SR] Detect dominant color for TextViews with Spans (#3682) * Bump github/codeql-action from 3.26.6 to 3.26.7 (#3692) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4dd1613...8214744) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump gradle/actions (#3691) Bumps [gradle/actions](https://github.com/gradle/actions) from fd87365911aa12c016c307ea21313f351dc53551 to 0d30c9111cf47a838eb69c06d13f3f51ab2ed76f. - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@fd87365...0d30c91) --- updated-dependencies: - dependency-name: gradle/actions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [SR] Add custom redaction options (#3689) * Add support for `feedback` envelope header item type (#3687) * Bump github/codeql-action from 3.26.7 to 3.26.8 (#3708) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.7 to 3.26.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8214744...294a9d9) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Ensure app context is used even when SDK is initialized via Activity Context (#3669) * Ensure app context is used even when SDK is initialized via Activity Context * Update Changelog * Exclude saucelabs from leakcanary * Exclude saucelabs TouchListener from leakCanary * Allow leakcanary for non-debug ui-test builds * Fix lint * Adds breadcrumb origin field (#3727) * Adds breadcrumb origin field * Updates api dump * Updates test cases * Updates serialisation tests * Adds changelog * Exclude testfairy from obfuscation * Revert "Exclude testfairy from obfuscation" This reverts commit 9900d1e. * Exclude any testfairy touchlistener static fields from LeakCanary --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * Replace Calendar.getInstance with System.currentTimeMillis for breadcrumb ctor (#3736) * chore(readme): Add info about updated release channels (#3773) * Update README.md * fix copy/paste error * [QA] Lazily load SentryOptions members (#3749) * Make AtomicClientReportStorage constructor lazy * Lazily initialize things we dont need * Empty experimental options * Format code * Make LazyEvaluator thread-safe * Fix tests * Fix .api * Use LazyEvaluator for heavy SentryOptions * Changelog * revert * tests --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * [QA] Fix potential ANRs due to default integrations (#3778) * Fix don't register any full drawn listeners if feature is not enabled * Offload app components breadcrumbs to background thread * Offload system events breadcrumbs to background thread * Update Changelog * Fix flaky tests * Remove session breadcrumbs * Fix tests * Address PR feedback * [SR] Support Jetpack Compose redaction (#3739) * WIP * Compose works * Custom redaction works for Compose * Formatting * Clean up * Test * Add tests * Changelog * Replace logo with sentry * formatting * Faster boundsInWindow for compose * api dump * Dont use liveliterals * [SR] Change terminology from redact/ignore to mask/unmask (#3741) * WIP * Compose works * Custom redaction works for Compose * Formatting * Clean up * Test * Add tests * Changelog * Change terminology from redact/ignore to mask/unmask * Changelog * [SR] Mask web and video views (#3775) * Replace logo with sentry * Add missing proguard rules * formatting * Faster boundsInWindow for compose * api dump * Dont use liveliterals * Remove redundant test * Increase timeout in failing test * release: 7.15.0 * Deprecate `enableTracing` in v7 (#3777) * deprecate enableTracing * changelog * replace synchronized with reentrant lock * downgrade coil to 2.0.0 to fix build problems --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefano <stefano.siano@sentry.io> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Krystof Woldrich <krystof.woldrich@sentry.io> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>

App start now takes AppStartMetrics.appLaunchedInForeground variable …

fa15544

…to add spans to the transaction App starts longer than 1 minute are dropped (same as Firebase)

updated changelog

a12a15c

added tests

stefanosiano marked this pull request as ready for review July 4, 2024 15:44

stefanosiano requested review from adinauer, romtsn and markushi as code owners July 4, 2024 15:44

markushi approved these changes Jul 5, 2024

View reviewed changes

romtsn reviewed Jul 5, 2024

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/ContextUtils.java Outdated Show resolved Hide resolved

romtsn reviewed Jul 5, 2024

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java Outdated Show resolved Hide resolved

stefanosiano added 2 commits July 5, 2024 19:29

added Activity lifecycle registration to check start launch time and …

bf5e505

…foreground status updated tests

updated api file

c2b6daa

romtsn reviewed Jul 9, 2024

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java Outdated Show resolved Hide resolved

romtsn reviewed Jul 9, 2024

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java Outdated Show resolved Hide resolved

stefanosiano added 2 commits July 10, 2024 10:34

changed AppStartMetrics to use ActivityLifecycleCallbacksAdapter

31d9b25

added app launch foreground check to AppStartMetrics ctor

added AppStartMetrics.registerApplicationForegroundCheck in the Sentr…

9b09e73

…yPerformanceProvider, other than AppStartMetrics.onApplicationCreate

romtsn reviewed Jul 10, 2024

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java Show resolved Hide resolved

zhukic mentioned this pull request Jul 11, 2024

Incorrect cold app start measurement when the app was opened after recev push notification receive #3567

Closed

added AppStartMetrics automatically unregister lifecycle callback

082edcb

added foreground check to SentryAndroid.init

romtsn approved these changes Jul 16, 2024

View reviewed changes

stefanosiano added 2 commits July 16, 2024 15:47

Merge branch 'main' into fix/app-start-foreground

a5b1e28

# Conflicts: # CHANGELOG.md # sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidTest.kt

ActivityLifecycleIntegration now reads first activity creation on cre…

93a9962

…ate instead of class instantiation AppStartMetrics callback is now registered only once AppStartMetrics stops app start profiler if no activity is being created

romtsn reviewed Jul 16, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

f33347d

Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>

stefanosiano merged commit 73237da into main Jul 17, 2024
24 of 26 checks passed

stefanosiano deleted the fix/app-start-foreground branch July 17, 2024 08:10

This was referenced Jul 25, 2024

Android transactions lasting for days, TTID halfway in, all spans at the very end. #3329

Closed

[Starfish] Use a better way to determine app foreground launch #3084

Closed

krystofwoldrich mentioned this pull request Aug 6, 2024

Use appLaunchedInForeground to determinate invalid app start data on Android getsentry/sentry-react-native#3995

Closed

krystofwoldrich mentioned this pull request Aug 6, 2024

Use appLaunchedInForeground to determinate invalid app start data on Android getsentry/sentry-dart#2215

Closed

kahest mentioned this pull request Aug 27, 2024

[Epic] App Start/TTID instrumentation improvements getsentry/team-mobile#193

Closed

antonis mentioned this pull request Oct 4, 2024

Use appLaunchedInForeground to determine invalid app start data on Android getsentry/sentry-react-native#4146

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check app start spans time and foreground state #3550

Check app start spans time and foreground state #3550

stefanosiano commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading

Previous results on branch: fix/app-start-foreground

Startup times

App size

markushi left a comment

kahest commented Jul 11, 2024

romtsn left a comment

Check app start spans time and foreground state #3550

Check app start spans time and foreground state #3550

Conversation

stefanosiano commented Jul 4, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jul 4, 2024 • edited Loading

Performance metrics 🚀

Previous results on branch: fix/app-start-foreground

Startup times

App size

markushi left a comment

Choose a reason for hiding this comment

kahest commented Jul 11, 2024

romtsn left a comment

Choose a reason for hiding this comment

stefanosiano commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading