-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Fix Session Replay crashes #3628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
August 8, 2024 13:56
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c8b47a8 | 455.28 ms | 517.40 ms | 62.12 ms |
762eced | 394.98 ms | 447.31 ms | 52.33 ms |
ab0933b | 409.00 ms | 500.18 ms | 91.18 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c8b47a8 | 1.70 MiB | 2.35 MiB | 660.42 KiB |
762eced | 1.70 MiB | 2.35 MiB | 660.15 KiB |
ab0933b | 1.70 MiB | 2.35 MiB | 660.20 KiB |
markushi
approved these changes
Aug 9, 2024
Base automatically changed from
rz/feat/session-replay-flutter-gestures
to
main
August 9, 2024 09:09
An error occurred while trying to automatically change base from
rz/feat/session-replay-flutter-gestures
to
main
August 9, 2024 09:09
stefanosiano
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes some crashes reported in our sdk-crashes-java project. Most of them are due to some weird devices behavior, but one with executor service was our fault as we were submitting without handling
RejectedExecutionException
.💡 Motivation and Context
Fixes #3618
Fixes #3631
Fixes getsentry/sentry-react-native#3990
Part of getsentry/sentry#74441
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps