Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Fix Session Replay crashes #3628

Merged
merged 23 commits into from
Aug 12, 2024
Merged

[SR] Fix Session Replay crashes #3628

merged 23 commits into from
Aug 12, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Aug 8, 2024

📜 Description

Fixes some crashes reported in our sdk-crashes-java project. Most of them are due to some weird devices behavior, but one with executor service was our fault as we were submitting without handling RejectedExecutionException.

💡 Motivation and Context

Fixes #3618
Fixes #3631
Fixes getsentry/sentry-react-native#3990

Part of getsentry/sentry#74441

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.84 ms 517.82 ms 67.98 ms
Size 1.70 MiB 2.35 MiB 660.43 KiB

Previous results on branch: rz/fix/session-replay-crashes

Startup times

Revision Plain With Sentry Diff
c8b47a8 455.28 ms 517.40 ms 62.12 ms
762eced 394.98 ms 447.31 ms 52.33 ms
ab0933b 409.00 ms 500.18 ms 91.18 ms

App size

Revision Plain With Sentry Diff
c8b47a8 1.70 MiB 2.35 MiB 660.42 KiB
762eced 1.70 MiB 2.35 MiB 660.15 KiB
ab0933b 1.70 MiB 2.35 MiB 660.20 KiB

Base automatically changed from rz/feat/session-replay-flutter-gestures to main August 9, 2024 09:09
An error occurred while trying to automatically change base from rz/feat/session-replay-flutter-gestures to main August 9, 2024 09:09
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@romtsn romtsn enabled auto-merge (squash) August 12, 2024 17:28
@romtsn romtsn merged commit f6e97b1 into main Aug 12, 2024
25 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-crashes branch August 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants