Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable serialization of multiple DOM attributes for breadcrumbs. #3755

Merged
merged 1 commit into from
Jun 28, 2021
Merged

feat: Enable serialization of multiple DOM attributes for breadcrumbs. #3755

merged 1 commit into from
Jun 28, 2021

Conversation

onurtemizkan
Copy link
Collaborator

Resolves: #3738

@onurtemizkan onurtemizkan changed the title feat: Enable serialization of multiple attributes of DOM breadcrumbs. feat: Enable serialization of multiple DOM attributes for breadcrumbs. Jun 27, 2021
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.39 KB (+0.27% 🔺)
@sentry/browser - Webpack 22.41 KB (+0.23% 🔺)
@sentry/react - Webpack 22.44 KB (+0.23% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.88 KB (+0.23% 🔺)

HazAT
HazAT approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@HazAT HazAT merged commit a3f70d8 into master Jun 28, 2021
@HazAT HazAT deleted the feat/serialize-multiple-attrs branch June 28, 2021 09:48
1999 added a commit to 1999/sentry-javascript that referenced this pull request Jun 30, 2021
@1999
Merge remote-tracking branch 'upstream/master' into dsorin/forge-add-…
85af3f7 
…transport

* upstream/master:
  fix(tracing): Add check for document.scripts in metrics (getsentry#3766)
  ref(nextjs): Stop setting redundant `productionBrowserSourceMaps` in config (getsentry#3765)
  test: Ensure withScope and run bubble up exceptions (getsentry#3764)
  ref(gatsby): Default release to empty string (getsentry#3759)
  fix(nextjs): Make `withSentryConfig` return type match given config type (getsentry#3760)
  misc: Fix typos (getsentry#3763)
  fix(node): Enable autoSessionTracking correctly (getsentry#3758)
  release: 6.8.0
  meta: 6.8.0 changelog
  feat: Enable serialization of multiple DOM attributes for breadcrumbs. (getsentry#3755)
  ref: Leave only valid buffer implementation (getsentry#3744)
This was referenced Jun 30, 2021
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Change new serializeAttribute option in breadcrumbs to an array
2 participants
@onurtemizkan @HazAT