Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Enable autoSessionTracking correctly #3758

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

AbhiPrasad
Copy link
Member

Fixes #3754.

If the autoSessionTracking option is undefined, we should be setting it to be true, not false.

Fixes #3754.

If the autoSessionTracking option is undefined, we should be setting
it to be true, not false.
@AbhiPrasad AbhiPrasad requested a review from ahmedetefy June 28, 2021 11:26
@AbhiPrasad AbhiPrasad requested a review from kamilogorek as a code owner June 28, 2021 11:26
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 28, 2021 11:32
@AbhiPrasad AbhiPrasad merged commit 8ea6c9d into master Jun 28, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-fix-auto-session-tracking branch June 28, 2021 11:38
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.4 KB (+0.01% 🔺)
@sentry/browser - Webpack 22.4 KB (0%)
@sentry/react - Webpack 22.44 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.89 KB (+0.01% 🔺)

1999 added a commit to 1999/sentry-javascript that referenced this pull request Jun 30, 2021
…transport

* upstream/master:
  fix(tracing): Add check for document.scripts in metrics (getsentry#3766)
  ref(nextjs): Stop setting redundant `productionBrowserSourceMaps` in config (getsentry#3765)
  test: Ensure withScope and run bubble up exceptions (getsentry#3764)
  ref(gatsby): Default release to empty string (getsentry#3759)
  fix(nextjs): Make `withSentryConfig` return type match given config type (getsentry#3760)
  misc: Fix typos (getsentry#3763)
  fix(node): Enable autoSessionTracking correctly (getsentry#3758)
  release: 6.8.0
  meta: 6.8.0 changelog
  feat: Enable serialization of multiple DOM attributes for breadcrumbs. (getsentry#3755)
  ref: Leave only valid buffer implementation (getsentry#3744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoSessionTracking default value set incorrectly?
2 participants