Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(gatsby): Default release to undefined #3759

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Conversation

AbhiPrasad
Copy link
Member

To make gatsby work better out of the box, we set the default for the release value to be undefined instead of an empty string.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@AbhiPrasad AbhiPrasad requested a review from kamilogorek as a code owner June 28, 2021 19:03
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 28, 2021 19:07
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.39 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.4 KB (0%)
@sentry/react - Webpack 22.44 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.88 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad force-pushed the abhi-gatsby-release branch from 93fab68 to 242525a Compare June 28, 2021 19:47
To make gatsby work better out of the box, we set the default
for the release value to be undefined instead of an empty string.
@AbhiPrasad AbhiPrasad force-pushed the abhi-gatsby-release branch from 242525a to cf05740 Compare June 29, 2021 13:51
@AbhiPrasad AbhiPrasad merged commit 3f53fef into master Jun 29, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-gatsby-release branch June 29, 2021 14:04
@lobsterkatie lobsterkatie changed the title ref(gatsby): Default release to empty string ref(gatsby): Default release to undefined Jun 29, 2021
1999 added a commit to 1999/sentry-javascript that referenced this pull request Jun 30, 2021
…transport

* upstream/master:
  fix(tracing): Add check for document.scripts in metrics (getsentry#3766)
  ref(nextjs): Stop setting redundant `productionBrowserSourceMaps` in config (getsentry#3765)
  test: Ensure withScope and run bubble up exceptions (getsentry#3764)
  ref(gatsby): Default release to empty string (getsentry#3759)
  fix(nextjs): Make `withSentryConfig` return type match given config type (getsentry#3760)
  misc: Fix typos (getsentry#3763)
  fix(node): Enable autoSessionTracking correctly (getsentry#3758)
  release: 6.8.0
  meta: 6.8.0 changelog
  feat: Enable serialization of multiple DOM attributes for breadcrumbs. (getsentry#3755)
  ref: Leave only valid buffer implementation (getsentry#3744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants