Tween null check #45436
Closed
Tween null check #45436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash parsing a serialized Reference (3.2)
[fbx] Implement ColorIndex for Vertex Colors to ensure they are correct and duplicate vertexes correctly for multiple color attributes.
[3.2] Add a minimap to the GraphEdit
Image::resize_to_po2() now takes an optional p_interpolation parameter that it passes directly to resize() with default value INTERPOLATE_BILINEAR. GLES2: call resize_to_po2() with interpolate argument Call resize_to_po2() in GLES2 rasterizer storage with either INTERPOLATE_BILINEAR or INTERPOLATE_NEAREST depending on TEXTURE_FLAG_FILTER. This avoids filtering issues with non power of two pixel art textures. See #44379
[3.2] Remove any constraints connected to a Bullet body when removing it
[3.2] Add interpolation parameter to resize_to_po2()
The root cause of the issue is that OpenGL ES 2 does not support the `textureCubeLod` function. There are (optional) extensions to support this, but they don't appear to be exposed with the ES2 renderer (even though the hardware needed to support LOD features are certainly available.) The existing shim in `drivers/gles2/shaders/cubemap_filter.glsl` just creates a macro: ``` #define textureCubeLod(img, coord, lod) textureCube(img, coord) ``` But the third parameter of `textureCube` is actually a mip bias, not an absolute mip level. (And it doesn't seem to work regardless.) In this specific case, the `cubemap_filter` should only sample from the first level of the "source" panorama cubemap. In lieu of a method to force a lod level of zero, I've chosen to comment out the switchover from a 2D equirectangular panorama to the cubemap version of the same image, therefore always sampling roughness values from the 2D equirectangular panorama. This may cause additional artifacts or issues across the seam, but at least it prevents the glaringly obvious black areas. --- This same issue (no fragment texture LOD support) has rather large repercussions elsewhere too; it means materials with larger cubemap density (i.e. planar or distant objects) will be far rougher than expected. Since GLES 3 appears to properly support fragment `texture*Lod` functions, switching to the GLES 3 backend would solve this problem. --- Root cause discovered with help from @kaadmy.
Fix PanoramaSky artifacts on Android/GLES2
Batching - Protection against zero and small sized ninepatches
Fix Variant conversion to float instead of double
…l directories on Windows.
These were only put in for the betas, in order to test hypotheses for stalling on Macs. It seems that most of the problems in the Mac editor have been solved by fixing the excessive redraw_requests. As a result no one has reported any results from these options, but in future we will be able to refer users to try the beta versions, so there is no need to include them in the stable release. Indeed they are only likely to cause confusion.
Remove buffer orphaning options project settings
[3.2] Fix file drag-drop on M1 Macs.
[3.2] Fix the `String::get_base_dir()` logic to properly check for top level directories on Windows
[3.2] Lightness of dynamic objects from Energy BakedLightmapData
[3.2] Use base character advances for outline drawing.
Partially revert change allowing sprite get_rect snapping to be controlled by `pixel_snap` again rather than `transform_snap` (to prevent breaking compatibility). Adds a final `use_camera_snap` project setting to allow snapping viewports as in reduz original PR.
[3.2] Fix ETC quality setting
Properly apply auto exposure with FXAA in GLES3
[3.2] Add missing "normalized" accessor property to glTF document
Ninepatch code has a check to prevent use of zero sized textures. This didn't deal properly with animated textures, which use a proxy (link to another texture). This PR uses a generalised method of getting textures, with built in support for proxy textures and protection against infinite loops.
Batching - fix ninepatch proxy textures (e.g. animated)
BVH render tree new updating scheme
BVH broadphase creates objects with updated AABB to avoid extra checks
Remove thread after use to prevent memory leak
Leaves in the bug fixes, but reverts the change to the update method. Turns out the new update method of getting the scenarios was causing problems, I will need to consult with reduz on the best way of getting access to the scenarios for a single update per frame. Doing multiple updates isn't terrible but it should be nicer to get a single update working, as it should be more efficient, and give a single point for pairing callbacks.
Partially revert change to BVH render tree update method
Fix freeze-crash in lightmapper under MinGW-GCC (3.2)
Fixes several instances of error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers] This looks like it was fixed in 6607fc7 when FBX was merged into the 4.0 master branch: "- fixed const correctness with C++/C version change"
[3.2] Fix const warnings in FBX (build failure on macOS)
Norrox
requested review from
aaronfranke,
akien-mga,
AndreaCatania,
hpvb,
JFonS,
neikeq,
reduz,
vnen and
a team
as code owners
aaronfranke
removed request for
a team,
aaronfranke,
hpvb,
JFonS,
akien-mga,
vnen,
reduz,
neikeq and
AndreaCatania
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45399